Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1868 Follow Up #2602

Merged
merged 3 commits into from
Aug 2, 2024
Merged

PIMS-1868 Follow Up #2602

merged 3 commits into from
Aug 2, 2024

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-1868

Following up on some comments about the ticket from Josh

Changes

  • Fixed the PID handling in the properties table when using the keyword filter search
  • Added some more select field filter options
    • Josh wants the option to filter by projects in SPL, but I think that would require utilizing the workflows. Many statuses could fall into SPL territory, but we have no way of showing that in the frontend at the moment.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented Aug 2, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2602. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Aug 2, 2024

Code Climate has analyzed commit 16e7100 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.9%.

View more on Code Climate.

Copy link

github-actions bot commented Aug 2, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2602. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I can edit a PID search in the map filter, and the quick filters on the tables work well. No issues found.

@dbarkowsky dbarkowsky merged commit cf99089 into main Aug 2, 2024
13 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1868-Follow-Up branch August 2, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants