PIMS-1871: Fuzzy search is returning properties already in other projects

[LawrenceLau2020]

🎯 Summary

PIMS-1871:

Changes

• Added a subquery to the fuzzy search to exclude properties that are already in projects.

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The Express API Image has been built with the tag: 2590. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit f2c5b0a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 90.9% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.9%.

View more on Code Climate.

[dbarkowsky]

The subquery is checking for cases where the property belongs to any project, but are users allowed to add properties to projects if they were previously part of a cancelled project? Would be nice if there was a way to do that.

[LawrenceLau2020]

I've added a couple sub queries for both the parcelsQuery and the buildingsQuery to try to include properties that don't belong to any projects as well as belonging to "Cancelled" projects. Could use a second pair of eyes right now, try searching for a building that doesn't belong to any project, I think the query includes the building, but it isn't showing up because the query might not be ordering the results correctly.

The parcel query needs testing as well and possible refactoring, as I was just trying to get the buildingsQuery to work properly first.