-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1945: Property views exclude deleted rows #2589
Conversation
🚀 Deployment Information The Express API Image has been built with the tag: |
Code Climate has analyzed commit 0d26d72 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.5%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by deleting a property and then seeing if it could be accessed.
Request no longer returns the soft-deleted property. 👍
… notify the parcel map to refresh whenever a property is deleted in another tab
🎯 Summary
PIMS-1945
Added deleted_on clause to view definitions and created relevant migration.
Note that if you follow the workflow of search property on map -> open property from map in new tab -> delete property, if you look back at the original tab the property won't appear as gone until you take some action that queries the view again. Not sure if there's much we can do about this though.
🔰 Checklist