Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1945: Property views exclude deleted rows #2589

Merged
merged 5 commits into from
Jul 31, 2024

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-1945

Added deleted_on clause to view definitions and created relevant migration.

Note that if you follow the workflow of search property on map -> open property from map in new tab -> delete property, if you look back at the original tab the property won't appear as gone until you take some action that queries the view again. Not sure if there's much we can do about this though.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2589. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Jul 30, 2024

Code Climate has analyzed commit 0d26d72 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.5%.

View more on Code Climate.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by deleting a property and then seeing if it could be accessed.
Request no longer returns the soft-deleted property. 👍

… notify the parcel map to refresh whenever a property is deleted in another tab
@dbarkowsky dbarkowsky self-requested a review July 31, 2024 17:47
@GrahamS-Quartech GrahamS-Quartech merged commit 2b6c5f8 into main Jul 31, 2024
13 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1945-ViewsExcludeDeletedRows branch July 31, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants