Pims-1858 Truncate Address From Geocoder

[TaylorFries]

🎯 Summary

PIMS-1858:

Made the following changes:

• truncated address on first comma from geocoder
• updated address model for geocoder
  • is fields were being returned as a string not bool
  • also updated logic for creating address1
  • more work will have to go into this logic block before we use it
• added a 10m setback to geocoder call
  • theoretically this should move the point away from the road and toward the center of the parcel
  • I have found a few instances that it still misses the parcel

🔰 Checklist

• I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.

• I have performed a self-review of my code.
• I have commented my code, particularly in hard-to-understand areas.
• I have made corresponding changes to the documentation where required.
• I have tested my changes to the best of my ability.
• My changes generate no new warnings.

[github-actions]

🚀 Deployment Information

The React APP Image has been built with the tag: 2523. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

[codeclimate]

Code Climate has analyzed commit 132ca7f and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.7%.

View more on Code Climate.

[dbarkowsky]

Was curious about what this locationDescriptor did, so I did some tests with it on/off:
All tests done with 467 Lampson St.
With lines 37 and 38 commented out, I get this:

With line 38 commented out only, I get this:

And with both lines present, I get this:

It seems like adding these lines might have reduced the accuracy of the location somehow.

Yet, with 1407 Haultain St (a weird split parcel), I get this with them both active:

And this with neither active:

With them, accuracy was 2/2 checked. Without, it was 1/2. so I think it's still worth it.

[TaylorFries]

It really could go either way - it just depends on each parcel. But I found the same, on parcels that geocoder sends a good point it makes the point worse but still acceptable, on parcels that geocoder sends a bad point it makes it better.