Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1826 Fuzzy Search Options #2511

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Conversation

dbarkowsky
Copy link
Collaborator

🎯 Summary

PIMS-1826

Changes

  • Edit fuzzy search service to be case insensitive
  • Edit fuzzy search by PID to allow for leading zeroes and hyphens
  • Change how autocomplete options are rendered for the fuzzy search

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

github-actions bot commented Jul 9, 2024

🚀 Deployment Information

The Express API Image has been built with the tag: 2511. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

github-actions bot commented Jul 9, 2024

🚀 Deployment Information

The React APP Image has been built with the tag: 2511. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the APP deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Jul 9, 2024

Code Climate has analyzed commit 9e5ce73 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 66.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.7%.

View more on Code Climate.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests work as expected. Really like the property blurbs! no issues detected

@dbarkowsky dbarkowsky merged commit 34b5105 into main Jul 9, 2024
13 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1826-Fuzzy-Search-Options branch July 9, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants