Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1683: Agency Responses API #2381

Merged
merged 3 commits into from
May 10, 2024
Merged

Conversation

GrahamS-Quartech
Copy link
Contributor

🎯 Summary

PIMS-1683

  • Adds agency response handling to the project get endpoint and project put endpoint
  • Including a agency response object results in an upsert, omitting it will delete if it was present previously
  • Also contains some optimizations for the project get call to prevent slowdown/OOM crash.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

… removed, fixed tests to account for service changes
Copy link

🚀 Deployment Information

The Express API Image has been built with the tag: 2381. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented May 10, 2024

Code Climate has analyzed commit f7884ce and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3%.

View more on Code Climate.

Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with these changes. Speed difference noticed (for the better!)

@GrahamS-Quartech GrahamS-Quartech merged commit 001d29e into main May 10, 2024
5 checks passed
@GrahamS-Quartech GrahamS-Quartech deleted the PIMS-1683-AgencyResponseAPI branch May 10, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants