PIMS-1623/1622: Handling project notifications and tasks #2370
Conversation
…e properties on PUT
… Fixed some logic in Task updating too. Implemented a way to update tasks when transitioning to a new status in the frontend. Revamped the documentation data card to show an immutable list of tasks organized by status.
|
🚀 Deployment Information The React APP Image has been built with the tag: |
…ed project correctly
GrahamS-Quartech
requested review from
LawrenceLau2020,
Sharala-Perumal,
dbarkowsky,
TaylorFries and
ManishSihag
as code owners
|
Code Climate has analyzed commit 05d6671 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.1%. View more on Code Climate. |
Yeah, this will just have to be another task kinda like the agency interest responses. Bummer that we sorta missed these in the initial design phase. |
| await projectRepo.save({ ...project, Metadata: newMetadata }); | ||
| await projectRepo.save({ ...project, Metadata: newMetadata, Tasks: undefined }); | ||
| //Seems this save will also try to save Tasks array if present, but if missing the ProjectId it will do weird stuff. | ||
| //So we could consolidate handleProjectTasks to here if we wanted, but then it might be annoying trying to get the more specific behavior in that function. |
There was a problem hiding this comment.
Had this issue on a previous PR. Thought turning cascade off for that relationship would have helped, but I guess not. I think this works good enough.
| if (!data || !tasks || !statuses) { | ||
| return {}; | ||
| } | ||
| //Somewhat evil reduce where we collect information from the status and tasks lookup so that we can |
| import { Box, Paper, Typography } from '@mui/material'; | ||
| import React from 'react'; | ||
|
|
||
| const Forbidden = () => { |
There was a problem hiding this comment.
Would be good for redirections through the AuthGuard.
There was a problem hiding this comment.
Comitted this by accident... A leftover from when I was trying to do exactly that. We probably actually will want this eventually so I guess I won't get rid of it.
…into DisposalProjectBasicWorkflow
🎯 Summary
PIMS-1623
PIMS-1622
🔰 Checklist