-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-1525 Active status check backend #2354
Conversation
🚀 Deployment Information The Express API Image has been built with the tag: |
@@ -15,13 +16,13 @@ const router = express.Router(); | |||
// Endpoints for Admin Agencies | |||
router | |||
.route(`/`) | |||
.get(protectedRoute(), catchErrors(getAgencies)) | |||
.post(protectedRoute([Roles.ADMIN]), catchErrors(addAgency)); | |||
.get(protectedRoute(), activeUserCheck, catchErrors(getAgencies)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably should not have it, since we need to enumerate the agencies on the access request page before the keycloak user gets a row in the user table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I thought that came from the lookup routes. Will change.
Code Climate has analyzed commit e102f5a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.5%. View more on Code Climate. |
🎯 Summary
PIMS-1525
Changes
Tried to determine which routes this was needed on, but feel free to make suggestions if you see something out of place.
🔰 Checklist