Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1430 User Table Tidy #2253

Merged
merged 10 commits into from
Mar 15, 2024
Merged

PIMS-1430 User Table Tidy #2253

merged 10 commits into from
Mar 15, 2024

Conversation

dbarkowsky
Copy link
Collaborator

@dbarkowsky dbarkowsky commented Mar 15, 2024

🎯 Summary

PIMS-1430

Provides some updates around the User Table and User Details experience.

Changes

  • Display Name field removed. Replaced with Provider column (IDIR or BCeID)
  • Solved issue where rendering would fail if pimsUser.data was undefined
  • Clicking Users in the header now returns you to the user table if you were on User Detail
  • User Detail has its own URL, so the back button in the browser works and you can save the URL to go straight to that user
  • Column sizes adjusted
  • Updated quick select options to include additional roles, statuses
  • Solved issue where trying to highlight text in rows would navigate you to User Detail upon mouseUp event. Now checks for selection length before deciding to navigate or not.
  • Provided option to pass initial state of table through props. We might not want to default sort by CreatedOn for every table.

Future Work

I wanted to implement something that would save the filter when navigating between the User Table and the User Details pages. I think there's a solution where we could save the filter and quick filter settings to a cookie and check that cookie upon load, but I'm going to start a new ticket for this solution to be generic for all tables.

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link
Collaborator

@TaylorFries TaylorFries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user table updates look good with test data. no issues detected

@dbarkowsky dbarkowsky merged commit 5114b19 into main Mar 15, 2024
5 checks passed
@dbarkowsky dbarkowsky deleted the PIMS-1430-User-Table-Tidy branch March 15, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants