Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIMS-1335 create deleteParcelByPid service #2212

Merged
merged 10 commits into from
Feb 27, 2024
Merged

PIMS-1335 create deleteParcelByPid service #2212

merged 10 commits into from
Feb 27, 2024

Conversation

TaylorFries
Copy link
Collaborator

@TaylorFries TaylorFries commented Feb 26, 2024

🎯 Summary

PIMS-1335:

Create deleteParcelBiPid service and tests

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

Copy link

🚀 Deployment Information

The API Image has been built with the tag: 2212. Please make sure to utilize this specific tag when promoting these changes to the TEST and PROD environments during the API deployment. For more updates please monitor Image Tags Page on Wiki.

Copy link

codeclimate bot commented Feb 26, 2024

Code Climate has analyzed commit ea1855b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 93.5%.

View more on Code Climate.

@TaylorFries TaylorFries changed the title PIMS-1335 create deleteParcelBiPid service PIMS-1335 create deleteParcelByPid service Feb 26, 2024
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using ThunderClient. Responses come back as expected.

@TaylorFries TaylorFries merged commit a24f293 into main Feb 27, 2024
5 checks passed
@TaylorFries TaylorFries deleted the PIMS-1335 branch February 27, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants