PIMS-680/1294: Admin Users View UI & Access Request Submission #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation, could be improved to avoid redundant 401s when requesting without the bearer loaded.
…mented an authrouteguard to make sure the necessary context is available before making authenticated calls and rendering pages
… fetching data within react components. Included some example usage for the DevZone.
… some basic data formatters
…o work with windows (hopefully)
…ct itself from the db, plus some context/hook to use this in the frontend
…e basic flow of adding a user/access request
dbarkowsky
requested changes
Feb 8, 2024
…so that you can now modify user fields
…he currently logged in user.
…e pending required fields
GrahamS-Quartech
requested review from
LawrenceLau2020,
Sharala-Perumal and
TaylorFries
as code owners
GrahamS-Quartech
changed the title
…lete vlue for the first time'
…PIMS into PIMS-680-AdminUsersViewUI
dbarkowsky
approved these changes
Feb 15, 2024
| options={[ | ||
| //TODO: Get these through a lookup endpoint. | ||
| { label: 'Active', value: 'Active' }, | ||
| { label: 'OnHold', value: 'OnHold' }, |
There was a problem hiding this comment.
Minor readable change.
Suggested change
| { label: 'OnHold', value: 'OnHold' }, | |
| { label: 'On Hold', value: 'OnHold' }, |
…o PIMS-680-AdminUsersViewUI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Summary
PIMS-680
Not wired up to the API in this state, for that I need 1260 merged in.
Was also considering making the form bits into their own reusable component, but I'm not sure how generic one could make it. I feel like there's usually a lot of customization that needs to be done in terms of how the fields are placed, what types of field to use, what labels to use, so much so that a reusable component might be more cumbersome than just dropping in the field components into a grid as I've done here. Any thoughts on this?
PIMS-1294
Now you should be able to submit an access request! Except there is no access request table anymore, this just creates a user with status "OnHold."
🔰 Checklist