Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIMS-683 - Geocoder Service #2157

Merged
merged 31 commits into from
Feb 16, 2024
Merged

PIMS-683 - Geocoder Service #2157

merged 31 commits into from
Feb 16, 2024

Conversation

LawrenceLau2020
Copy link
Collaborator

@LawrenceLau2020 LawrenceLau2020 commented Jan 30, 2024 •
edited by TaylorFries
Loading

🎯 Summary

PIMS-683:

🔰 Checklist

  • I have read and agree with the following checklist and am following the guidelines in our Code of Conduct document.
  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation where required.
  • I have tested my changes to the best of my ability.
  • My changes generate no new warnings.

@LawrenceLau2020 LawrenceLau2020 self-assigned this Jan 30, 2024
LawrenceLau2020 and others added 18 commits January 30, 2024 14:17
@LawrenceLau2020
Updating From column for project reports to nullable because first re…
ec385d0 
…cord is always null
@LawrenceLau2020
Merge branch 'main' into PIMS-683
183cd3a
@LawrenceLau2020
refining the service
6e1a0c5
@GrahamS-Quartech @TaylorFries
PIMS-669: User & Roles Services (#2037)
a5d0c64
@dbarkowsky @TaylorFries
PIMS-545 Transfer Keycloak Users-Roles (#2166)
59db332
@dbarkowsky @TaylorFries
PIMS-408 Establish Migration Options (#2164)
c26631e
@TaylorFries
Sprint 14 Updating express-api minor NPM Dependencies (#2170)
0baf563
@TaylorFries
Sprint 14 Updating Frontend NPM Packages (minor updates) (#2169)
3d3c105
@GrahamS-Quartech @dbarkowsky @TaylorFries
PIMS-1260: React API Hooks (#2167)
4904225 
Co-authored-by: Dylan Barkowsky <[email protected]>
@dbarkowsky @TaylorFries
PIMS-1201 Update react-app Dependencies (#2174)
5baad42
@dbarkowsky @TaylorFries
PIMS-668 Users Table (#2148)
88fb798
@dbarkowsky @TaylorFries
PIMS-1275 Update react-datepicker to 6.1.0 (frontend) (#2180)
c6ce531
@dbarkowsky @TaylorFries
PIMS-1298 Update react-router-dom to 6.22.0 (frontend) (#2179)
238744b
@dbarkowsky @TaylorFries
PIMS-1287 Updated @types/supertest to 6.0.2 (express-api) (#2178)
ff6f3e7
@dbarkowsky @TaylorFries
PIMS-1236 Updated prettier to 3.2.4 (express-api) (#2177)
43796c8
@Sharala-Perumal @dbarkowsky
@GrahamS-Quartech @TaylorFries
PIMS-407: Seed Data in Postgres (#2165)
dd1f409 
Co-authored-by: dbarkowsky <[email protected]>
Co-authored-by: Dylan Barkowsky <[email protected]>
Co-authored-by: Graham Stewart <[email protected]>
@dbarkowsky @TaylorFries
PIMS-1311 Updating Role Mapper Names (#2181)
e940027 
Co-authored-by: TaylorFries <[email protected]>
@ManishSihag @TaylorFries
Express api Github action workflow (#2175)
2de3d3e
@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 16, 2024 •
edited
Loading

Code Climate has analyzed commit c87a5db and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 89.1% (50% is the threshold).

This pull request will bring the total coverage in the repository to 90.9%.

View more on Code Climate.

@TaylorFries TaylorFries marked this pull request as ready for review February 16, 2024 19:02
@TaylorFries TaylorFries self-assigned this Feb 16, 2024
dbarkowsky
dbarkowsky approved these changes Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@dbarkowsky dbarkowsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great. One commented line that could be removed.
I pushed an update to the .env-template so it would include the geocoder key as a possibility. That file was overdue for an update anyway.

express-api/src/services/geocoder/geocoderService.ts Outdated Show resolved Hide resolved
@TaylorFries TaylorFries merged commit 4d3375b into main Feb 16, 2024
5 checks passed
@TaylorFries TaylorFries deleted the PIMS-683 branch February 16, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbarkowsky dbarkowsky dbarkowsky approved these changes

@Sharala-Perumal Sharala-Perumal Awaiting requested review from Sharala-Perumal Sharala-Perumal is a code owner

@TaylorFries TaylorFries Awaiting requested review from TaylorFries TaylorFries is a code owner

@GrahamS-Quartech GrahamS-Quartech Awaiting requested review from GrahamS-Quartech

Assignees

@LawrenceLau2020 LawrenceLau2020

@TaylorFries TaylorFries

Labels
Docker Express OpenShift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LawrenceLau2020 @TaylorFries @dbarkowsky @GrahamS-Quartech @Sharala-Perumal @ManishSihag