-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIMS-668 Users Table #2148
PIMS-668 Users Table #2148
Conversation
Code Climate has analyzed commit 6a6f487 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 93.8%. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Table looks great!
Filtering works as expected, table is responsive to window size, paging works well, and search feature works.
Code looks good and is well documented in my opinion.
I want to wait to merge this until it has been modified to work with the new API hooks and the recently merged backend code. |
Tested this, all works as expected. Some great new components in here too. I'll hold off on approval if you wanna wire this up to the hooks next though. |
🎯 Summary
PIMS-668
Changes
Testing
In order to test, you'll have to configure the get users endpoint to return some mock data.
Here's what I used for testing:
Expand Me
🔰 Checklist