temp

bcgov · Nov 16, 2024 · ae6eeb0 · ae6eeb0
1 parent de366c2
commit ae6eeb0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 15 deletions.
diff --git a/src/api/notifications/notifications.controller.ts b/src/api/notifications/notifications.controller.ts
@@ -83,19 +83,19 @@ enum NotificationDispatchStatusField {
 @ApiTags('notification')
 @Roles(Role.Admin, Role.SuperAdmin, Role.AuthenticatedUser)
 export class NotificationsController {
-  readonly appConfig;
-  readonly handleBounce;
-  readonly guaranteedBroadcastPushDispatchProcessing;
-  readonly broadcastSubscriberChunkSize;
-  readonly logSkippedBroadcastPushDispatches;
-  readonly inboundSmtpServerDomain;
-  readonly handleListUnsubscribeByEmail;
+  private readonly appConfig;
+  private readonly handleBounce;
+  private readonly guaranteedBroadcastPushDispatchProcessing;
+  private readonly broadcastSubscriberChunkSize;
+  private readonly logSkippedBroadcastPushDispatches;
+  private readonly inboundSmtpServerDomain;
+  private readonly handleListUnsubscribeByEmail;
 
   constructor(
     private readonly notificationsService: NotificationsService,
     private readonly subscriptionsService: SubscriptionsService,
-    readonly appConfigService: AppConfigService,
-    readonly configurationsService: ConfigurationsService,
+    private readonly appConfigService: AppConfigService,
+    private readonly configurationsService: ConfigurationsService,
     private readonly bouncesService: BouncesService,
     private readonly commonService: CommonService,
     @Inject(REQUEST) private readonly req: Request & { user: UserProfile },
@@ -105,8 +105,6 @@ export class NotificationsController {
     this.handleBounce = this.appConfig.email?.bounce?.enabled;
     this.guaranteedBroadcastPushDispatchProcessing =
       this.appConfig.notification?.guaranteedBroadcastPushDispatchProcessing;
-    const ft = this.appConfig.notification?.broadcastCustomFilterFunctions;
-
     this.broadcastSubscriberChunkSize =
       this.appConfig.notification?.broadcastSubscriberChunkSize;
     this.logSkippedBroadcastPushDispatches =
@@ -116,6 +114,7 @@ export class NotificationsController {
     this.handleListUnsubscribeByEmail =
       this.appConfig.email?.listUnsubscribeByEmail?.enabled;
 
+    const ft = this.appConfig.notification?.broadcastCustomFilterFunctions;
     if (ft) {
       this.jmespathSearchOpts.functionTable = ft;
     }

diff --git a/src/common/common.service.ts b/src/common/common.service.ts
@@ -63,17 +63,17 @@ export class CommonService {
         const queuedID = [];
         // IMPORTANT: place queueEvents.on before myQueue.add
         queueEvents.on('completed', async ({ jobId }) => {
-          Logger.debug(
-            `job ${jobId} completed on queueEventsListener for ${j?.id}`,
-            CommonService.name,
-          );
           if (!j?.id) {
             queuedID.push(jobId);
             return;
           }
           if (jobId !== j?.id) {
             return;
           }
+          Logger.debug(
+            `job ${jobId} completed on queueEventsListener for ${j?.id}`,
+            CommonService.name,
+          );
           try {
             resolve(await fn.apply(this, args));
           } catch (ex) {