Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version in JHA (12 -> 18, 22) #341

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

skylermcnamee-hibc
Copy link
Collaborator

Please check if the PR fulfills these requirements:

  • After these changes, the app was run and still works as expected
  • Tests for these changes were added (if applicable)
  • npm audit was checked, applicable vulnerabilities were updated
  • npm run build passes
  • npm run lint has no unexpected errors
  • npm run format was run on changed files
  • All existing unit tests were run and still pass
  • End-to-end tests were run and still pass (npm run test:e2e:headless)

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):

Updates build matrix in jha-web workflow to use both 18 and 22.

Update source strategy in build.yaml to use nodejs-18 rather than 12. (It's preferable to run JHA in 22 where possible for maximum compatibility with the pdf-js package, but it will build in 18, and that'll do for now while we wait for 22 to go into LTS and eventually become an image in the Redhat registry. Both of those options are better than 12, which fails everywhere.)

This change was manually added to OpenShift as well.

In summary:
Local development-- use node 22
jha-web.yaml Test step-- runs unit/e2e tests in 22 (node 18 can't properly run the unit tests due to pdf-js compatibility, but the application works fine in the browser and the tests pass in node 22)
jha-web.yaml Build step-- runs in 18 and 22 (should pass in both)
jha-web.yaml Image-build action-- set to nodejs-18 in the build.yaml and OpenShift (planned to upgrade to 22 when the LTS image becomes available)

Additional Notes:

npm run format changes will happen at a later date.

@skylermcnamee-hibc skylermcnamee-hibc merged commit 0a1f46c into main Sep 10, 2024
6 checks passed
@skylermcnamee-hibc skylermcnamee-hibc deleted the update-node-version branch September 10, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants