Update student contact was returning an object with a null schoolId a…

…nd also for nats message payload.
bcgov · Jun 27, 2024 · 5750ee6 · 5750ee6
1 parent 033dfb7
commit 5750ee6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/api/src/main/java/ca/bc/gov/educ/api/institute/service/v1/SchoolService.java b/api/src/main/java/ca/bc/gov/educ/api/institute/service/v1/SchoolService.java
@@ -308,11 +308,11 @@ public Pair<SchoolContactEntity, InstituteEvent> updateSchoolContact(SchoolConta
       schoolContactRepository.save(currentContactEntity);
       final InstituteEvent instituteEvent = EventUtil.createInstituteEvent(
               contact.getCreateUser(), contact.getUpdateUser(),
-              JsonUtil.getJsonStringFromObject(SchoolContactMapper.mapper.toStructure(contactEntity)),
+              JsonUtil.getJsonStringFromObject(SchoolContactMapper.mapper.toStructure(currentContactEntity)),
               UPDATE_SCHOOL_CONTACT, SCHOOL_CONTACT_UPDATED
       );
       instituteEventRepository.save(instituteEvent);
-      return Pair.of(contactEntity, instituteEvent);
+      return Pair.of(currentContactEntity, instituteEvent);
     } else {
       throw new EntityNotFoundException(SchoolContactEntity.class, CONTACT_ID_ATTR,
           String.valueOf(contactId));