Fix username for student history

bcgov · Aug 21, 2024 · c6629a1 · c6629a1
1 parent ca11635
commit c6629a1
Showing 1 changed file with 5 additions and 13 deletions.
diff --git a/api/src/test/java/ca/bc/gov/educ/api/gradstudent/service/HistoryServiceTest.java b/api/src/test/java/ca/bc/gov/educ/api/gradstudent/service/HistoryServiceTest.java
@@ -219,7 +219,6 @@ public  void testGetStudentOptionalProgramHistoryByID() {
     public void testGetStudentHistoryByBatchID() {
         // ID
         UUID studentID = UUID.randomUUID();
-        UUID historyID = UUID.randomUUID();
         List<GraduationStudentRecordHistoryEntity> histList = new ArrayList<>();
 
         Student std = new Student();
@@ -274,7 +273,6 @@ public void testGetStudentHistoryByBatchID() {
     public void testUpdateStudentRecordHistoryDistributionRun() {
         // ID
         UUID studentID = UUID.randomUUID();
-        UUID historyID = UUID.randomUUID();
         List<GraduationStudentRecordHistoryEntity> histList = new ArrayList<>();
 
         Student std = new Student();
@@ -306,7 +304,6 @@ public void testUpdateStudentRecordHistoryDistributionRun() {
         graduationStudentRecordHistoryEntity.setLegalMiddleNames("Adad");
         graduationStudentRecordHistoryEntity.setLegalLastName("sadad");
         histList.add(graduationStudentRecordHistoryEntity);
-        Pageable paging = PageRequest.of(0, 10);
         Page<GraduationStudentRecordHistoryEntity> hPage = new PageImpl(histList);
 
         GraduationStudentRecordEntity graduationStudentRecordEntity = new GraduationStudentRecordEntity();
@@ -318,25 +315,20 @@ public void testUpdateStudentRecordHistoryDistributionRun() {
         when(graduationStudentRecordRepository.findByStudentID(studentID)).thenReturn(graduationStudentRecordEntity);
 
         var result = historyService.updateStudentRecordHistoryDistributionRun(4000L, "USER", "activityCode", List.of(studentID));
-        assertThat(result).isNotNull();
-        assertThat(result).isEqualTo(0);
+        assertThat(result).isNotNull().isZero();
 
         when(graduationStudentRecordHistoryRepository.findByBatchId(4000L, PageRequest.of(0, Integer.SIZE))).thenReturn(null);
         result = historyService.updateStudentRecordHistoryDistributionRun(4000L, "USER", "activityCode", List.of(studentID));
-        assertThat(result).isNotNull();
-        assertThat(result).isEqualTo(1);
+        assertThat(result).isNotNull().isEqualTo(1);
 
         when(graduationStudentRecordHistoryRepository.findByBatchId(4000L, PageRequest.of(0, Integer.SIZE))).thenReturn(new PageImpl(List.of()));
         result = historyService.updateStudentRecordHistoryDistributionRun(4000L, "USER", "activityCode", List.of(studentID));
-        assertThat(result).isNotNull();
-        assertThat(result).isEqualTo(1);
+        assertThat(result).isNotNull().isEqualTo(1);
 
         result = historyService.updateStudentRecordHistoryDistributionRun(4000L, "USER", "activityCode", List.of());
-        assertThat(result).isNotNull();
-        assertThat(result).isEqualTo(0);
+        assertThat(result).isNotNull().isZero();
 
         result = historyService.updateStudentRecordHistoryDistributionRun(4000L, "USER", "", List.of());
-        assertThat(result).isNotNull();
-        assertThat(result).isEqualTo(0);
+        assertThat(result).isNotNull().isZero();
     }
 }