Merge pull request #585 from bcgov/feature/GRAD2-2325

Worked on performance to remove nongrad reason fileds for nongrad stu…
bcgov · Oct 24, 2023 · 89b6b32 · 89b6b32
2 parents 398ae18 + 914c373
commit 89b6b32
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 38 deletions.
diff --git a/api/src/main/java/ca/bc/gov/educ/api/gradstudent/model/dto/EdwGraduationSnapshot.java b/api/src/main/java/ca/bc/gov/educ/api/gradstudent/model/dto/EdwGraduationSnapshot.java
@@ -25,19 +25,6 @@ public class EdwGraduationSnapshot {
     private BigDecimal gpa;
     private String graduatedDate;
 
-    private String nonGradReason1;
-    private String nonGradReason2;
-    private String nonGradReason3;
-    private String nonGradReason4;
-    private String nonGradReason5;
-    private String nonGradReason6;
-    private String nonGradReason7;
-    private String nonGradReason8;
-    private String nonGradReason9;
-    private String nonGradReason10;
-    private String nonGradReason11;
-    private String nonGradReason12;
-
     @JsonFormat(pattern=DEFAULT_DATE_FORMAT)
     private LocalDate runDate;
     @JsonFormat(pattern=DEFAULT_DATE_FORMAT)

diff --git a/...rc/main/java/ca/bc/gov/educ/api/gradstudent/model/entity/EdwGraduationSnapshotEntity.java b/...rc/main/java/ca/bc/gov/educ/api/gradstudent/model/entity/EdwGraduationSnapshotEntity.java
@@ -28,31 +28,6 @@ public class EdwGraduationSnapshotEntity {
     @Column(name = "GRAD_DATE", nullable = true)
     private LocalDate graduatedDate;
 
-    @Column(name = "NOT_GRAD_REASON_1", nullable = true)
-    private String nonGradReason1;
-    @Column(name = "NOT_GRAD_REASON_2", nullable = true)
-    private String nonGradReason2;
-    @Column(name = "NOT_GRAD_REASON_3", nullable = true)
-    private String nonGradReason3;
-    @Column(name = "NOT_GRAD_REASON_4", nullable = true)
-    private String nonGradReason4;
-    @Column(name = "NOT_GRAD_REASON_5", nullable = true)
-    private String nonGradReason5;
-    @Column(name = "NOT_GRAD_REASON_6", nullable = true)
-    private String nonGradReason6;
-    @Column(name = "NOT_GRAD_REASON_7", nullable = true)
-    private String nonGradReason7;
-    @Column(name = "NOT_GRAD_REASON_8", nullable = true)
-    private String nonGradReason8;
-    @Column(name = "NOT_GRAD_REASON_9", nullable = true)
-    private String nonGradReason9;
-    @Column(name = "NOT_GRAD_REASON_10", nullable = true)
-    private String nonGradReason10;
-    @Column(name = "NOT_GRAD_REASON_11", nullable = true)
-    private String nonGradReason11;
-    @Column(name = "NOT_GRAD_REASON_12", nullable = true)
-    private String nonGradReason12;
-
     @Column(name = "RUN_DATE", nullable = true)
     private LocalDate runDate;
     @Column(name = "SESSION_DATE", nullable = true)

diff --git a/...src/main/resources/db/migration/1.0/V1.0.58__DDL-UPDATE_TABLE-EDW_GRADUATION_SNAPSHOT.sql b/...src/main/resources/db/migration/1.0/V1.0.58__DDL-UPDATE_TABLE-EDW_GRADUATION_SNAPSHOT.sql
@@ -0,0 +1,13 @@
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_1;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_2;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_3;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_4;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_5;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_6;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_7;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_8;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_9;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_10;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_11;
+ALTER TABLE EDW_GRADUATION_SNAPSHOT DROP COLUMN NOT_GRAD_REASON_12;
+