Fix username for student history

bcgov · Aug 20, 2024 · 1a38c30 · 1a38c30
1 parent cda1209
commit 1a38c30
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/api/src/main/java/ca/bc/gov/educ/api/gradstudent/controller/GradStudentController.java b/api/src/main/java/ca/bc/gov/educ/api/gradstudent/controller/GradStudentController.java
@@ -27,8 +27,7 @@ public class GradStudentController {
 
     @SuppressWarnings("unused")
 	private static final Logger logger = LoggerFactory.getLogger(GradStudentController.class);
-	private static final String BEARER = "Bearer ";
-
+
     private final GradStudentService gradStudentService;
 
     public GradStudentController(GradStudentService gradStudentService) {

diff --git a/api/src/main/java/ca/bc/gov/educ/api/gradstudent/service/GradStudentService.java b/api/src/main/java/ca/bc/gov/educ/api/gradstudent/service/GradStudentService.java
@@ -408,14 +408,20 @@ public List<UUID> getStudentIDsByStatusCode(List<UUID> studentIDs, String status
 
 	public List<UUID> getStudentIDsBySearchCriteriaOrAll(StudentSearchRequest searchRequest) {
 		ArrayList<UUID> result = new ArrayList<>();
-		result.addAll(searchRequest.getStudentIDs());
+		boolean paramsNotEmpty = false;
+		if(searchRequest.getStudentIDs() != null && !searchRequest.getStudentIDs().isEmpty()) {
+			paramsNotEmpty = true;
+			result.addAll(searchRequest.getStudentIDs());
+		}
 		if(searchRequest.getPens() != null && !searchRequest.getPens().isEmpty()) {
+			paramsNotEmpty = true;
 			result.addAll(graduationStatusRepository.findStudentIDsByPenIn(searchRequest.getPens()));
 		}
 		if(searchRequest.getSchoolOfRecords() != null && !searchRequest.getSchoolOfRecords().isEmpty()) {
+			paramsNotEmpty = true;
 			result.addAll(graduationStatusRepository.findBySchoolOfRecordIn(searchRequest.getSchoolOfRecords()));
 		}
-		if(result.isEmpty()) {
+		if(!paramsNotEmpty) {
 			result.addAll(graduationStatusRepository.findAllStudentGuids());
 		}
 		return result;