Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRAD2-2394: task is completed. #496

Merged
merged 2 commits into from
Nov 10, 2023
Merged

GRAD2-2394: task is completed. #496

merged 2 commits into from
Nov 10, 2023

Conversation

infstar
Copy link
Contributor

@infstar infstar commented Nov 10, 2023

GRAD2-2394: task is completed.

@infstar
GRAD2-2394: task is completed.
ef42274 
GRAD2-2394: task is completed.
@infstar
Improved to remove the potential NPE issue in TranscriptResult.
7cd344b 
Improved to remove the potential NPE issue in TranscriptResult.
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication

arybakov-cgi
arybakov-cgi suggested changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@arybakov-cgi arybakov-cgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure no NPE in getCompletedPercentage() if mark is null

@infstar infstar merged commit 8259233 into grad-release Nov 10, 2023
4 checks passed
@githubmamatha githubmamatha deleted the feature/GRAD2-2394 branch April 2, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arybakov-cgi arybakov-cgi arybakov-cgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infstar @arybakov-cgi