GRAD2-2639: initial implementation is done. #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRAD2-2639: initial implementation is done.
More unit tests to meet the new code coverage.
…oolId instead of mincode. GRAD2-2639: Regenerate School Reports batch job is updated to use schoolId instead of mincode.
Missing codes in listener are committed to use schoolId.
Unit tests as unexpected path are fixed to get more coverage.
cditcher
requested changes
Dec 24, 2024
api/src/main/java/ca/bc/gov/educ/api/batchgraduation/config/BatchJobConfig.java
Outdated
Show resolved
Hide resolved
...src/main/java/ca/bc/gov/educ/api/batchgraduation/reader/DeleteStudentReportsPartitioner.java
Outdated
Show resolved
Hide resolved
Minor changes after code review.
|
cditcher
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRAD2-2639: initial implementation is done.