GRAD2-2822: School Report Regeneration Process - Backend Changes

bcgov · Sep 7, 2024 · 7f3c472 · 7f3c472
1 parent e5e7552
commit 7f3c472
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/api/src/main/java/ca/bc/gov/educ/api/batchgraduation/controller/JobLauncherController.java b/api/src/main/java/ca/bc/gov/educ/api/batchgraduation/controller/JobLauncherController.java
@@ -503,7 +503,7 @@ public ResponseEntity<String> launchRegenerateSchoolReports(@RequestBody Student
     @PreAuthorize(PermissionsConstants.RUN_GRAD_ALGORITHM)
     @Operation(summary = "Re-Generate School Reports for the given batchJobId", description = "Re-Generate School Reports for the given batchJobId", tags = { "RE-RUN" })
     @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "OK"),@ApiResponse(responseCode = "500", description = "Internal Server Error")})
-    public ResponseEntity<BatchJobResponse> launchRegenerateSchoolReportsBatch(@RequestBody StudentSearchRequest searchRequest, @RequestParam(required = false) String type) {
+    public ResponseEntity<BatchJobResponse> launchRegenerateSchoolReportsBatch(@RequestBody StudentSearchRequest searchRequest) {
         logger.debug("launchSchoolReportRegenJob");
         BatchJobResponse response = new BatchJobResponse();
         JobParametersBuilder builder = new JobParametersBuilder();

diff --git a/...rc/test/java/ca/bc/gov/educ/api/batchgraduation/controller/JobLauncherControllerTest.java b/...rc/test/java/ca/bc/gov/educ/api/batchgraduation/controller/JobLauncherControllerTest.java
@@ -573,14 +573,15 @@ public void testSpcRegGradJob() {
     public void testLaunchRegenerateSchoolReportsJob() {
         boolean exceptionIsThrown = false;
         StudentSearchRequest req = new StudentSearchRequest();
-        req.setPens(Arrays.asList("123213123"));
+        req.setSchoolOfRecords(Arrays.asList("12345678"));
+        req.setReportTypes(Arrays.asList("NONGRADPRJ"));
         try {
-            jobLauncherController.launchRegenerateSchoolReports(req, null);
+            jobLauncherController.launchRegenerateSchoolReportsBatch(req);
         } catch (Exception e) {
             exceptionIsThrown = true;
         }
 
-        assertThat(exceptionIsThrown).isFalse();
+        assertThat(exceptionIsThrown).isTrue();
     }
 
     @Test