GRAD2-3119 #694
Merged
GRAD2-3119 #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .github/workflows/deploy-backend-to-ocp-test.yml
mightycox
reviewed
Dec 4, 2024
mightycox
reviewed
Dec 4, 2024
backend/src/routes/auth.js
Outdated
| config.get("server:frontend") + | ||
| "/session-expired" | ||
| ); | ||
| console.log("1") |
There was a problem hiding this comment.
No probably not. This was not my change but came in when I merged main into my branch to update it. I'll notify the UI team.
mightycox
reviewed
Dec 4, 2024
| --from-literal=REDIS_HOST=redis \ | ||
| --from-literal=REDIS_PORT=6379 \ | ||
| --from-literal=REDIS_PASSWORD="$REDIS_PASSWORD" \ | ||
| --from-literal=BATCH_API_URL="http://educ-grad-batch-graduation-api.77c02f-$ENV.svc.cluster.local:8080/api/v1" \ |
There was a problem hiding this comment.
is it ok to have namespace ids in the repo?
There was a problem hiding this comment.
I posed the question in RC to the platform team awhile back and the response was kind of luke warm about this. I have seen other teams using them in version control also which makes me think it's ok. But good catch anyway, I will change this.
mightycox
approved these changes
Dec 4, 2024
mightycox
approved these changes
Dec 5, 2024
# Conflicts: # .github/workflows/deploy-backend-to-ocp-test.yml # .github/workflows/deploy-frontend-to-ocp-test.yml # backend/src/routes/auth.js
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates include:
DeploymentConfig -> Deployment
Routes with certificates
Configmap update script for backend