Skip to content

Commit

Permalink
UI cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
SodhiA1 committed Nov 20, 2024
1 parent 5daa7e9 commit d30ed6b
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 30 deletions.
11 changes: 0 additions & 11 deletions backend/src/components/grad.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,6 @@ async function uploadFile(req, res) {
return handleExceptionResponse(e, res);
}
}
async function getFileProgress(req, res) {
try {
const token = getAccessToken(req);
const data = await getData(token, `${config.get('grad:rootURL')}/${req.params.schoolID}/file`, req.session?.correlationID);
return res.status(HttpStatus.OK).json(data);
} catch (e) {
log.error('getSdcFileProgress Error', e.stack);
return handleExceptionResponse(e, res);
}
}

async function getFilesetsPaginated(req, res) {
try {
Expand Down Expand Up @@ -187,7 +177,6 @@ function createMultiFieldNameSearchCriteria(nameString) {

module.exports = {
uploadFile,
getFileProgress,
getErrorFilesetStudentPaginated,
getFilesetsPaginated
};
7 changes: 2 additions & 5 deletions backend/src/routes/grad.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,19 @@ const auth = require('../components/auth');
const isValidBackendToken = auth.isValidBackendToken();
const { validateAccessToken, checkEdxUserPermission} = require('../components/permissionUtils');
const { scanFilePayload } = require('../components/fileUtils');
const { uploadFile, getFileProgress, getErrorFilesetStudentPaginated, getFilesetsPaginated} = require('../components/grad');
const { uploadFile, getErrorFilesetStudentPaginated, getFilesetsPaginated} = require('../components/grad');
const { PERMISSION } = require('../util/Permission');
const validate = require('../components/validator');
const {getCachedGradCollectionData} = require('../components/gdc-cache');
const constants = require('../util/constants');
const { gradFileUploadSchema, gradFileBySchoolIDSchema, gradErrorFilesetStudentPaginatedSchema} = require('../validations/grad');
const { gradFileUploadSchema, gradErrorFilesetStudentPaginatedSchema} = require('../validations/grad');

router.get('/validation-issue-type-codes', passport.authenticate('jwt', {session: false}, undefined), isValidBackendToken,
validateAccessToken, getCachedGradCollectionData(constants.CACHE_KEYS.GDC_VALIDATION_ISSUE_TYPE_CODES, 'grad:validationIssueTypeCodesURL'));

router.post('/school/:schoolID/upload-file', passport.authenticate('jwt', {session: false}, undefined), isValidBackendToken, validateAccessToken,
checkEdxUserPermission(PERMISSION.GRAD_SCH_EDIT), validate(gradFileUploadSchema), scanFilePayload, uploadFile);

router.get('/school/:schoolID/file-progress', passport.authenticate('jwt', {session: false}, undefined), isValidBackendToken, validateAccessToken,
checkEdxUserPermission(PERMISSION.GRAD_SCH_EDIT), validate(gradFileBySchoolIDSchema), getFileProgress);

router.get('/filesetErrors/:schoolID/paginated', passport.authenticate('jwt', {session: false}, undefined), isValidBackendToken, validateAccessToken,
checkEdxUserPermission(PERMISSION.GRAD_SCH_EDIT), validate(gradErrorFilesetStudentPaginatedSchema),
getErrorFilesetStudentPaginated);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@
<div
class="border"
>
<v-row>
<v-col class="mb-3 d-flex justify-center">
<h1>Graduation Projections and TVRs</h1>
</v-col>
</v-row>

<v-tabs
v-model="tab"
color="#38598a"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,6 @@
<div
class="border"
>
<v-row>
<v-col class="mb-3 d-flex justify-center">
<h1>Graduation Reports and Transcripts</h1>
</v-col>
</v-row>

<v-tabs
v-model="tab"
color="#38598a"
Expand Down
4 changes: 2 additions & 2 deletions frontend/src/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ const router = createRouter({
component: GradProjectionsTVR,
props: true,
meta: {
pageTitle: PAGE_TITLES.GRAD_DATA_COLLECTION,
pageTitle: PAGE_TITLES.GRAD_PROJECTIONS,
requiresAuth: true,
permission: PERMISSION.GRAD_SCH_EDIT
},
Expand All @@ -418,7 +418,7 @@ const router = createRouter({
component: GradReportsAndTranscripts,
props: true,
meta: {
pageTitle: PAGE_TITLES.GRAD_DATA_COLLECTION,
pageTitle: PAGE_TITLES.GRAD_REPORTS,
requiresAuth: true,
permission: PERMISSION.GRAD_SCH_EDIT
},
Expand Down

0 comments on commit d30ed6b

Please sign in to comment.