Ccfri 4274 closure data lost #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out on the summary dec page
… ccfri-4274-closure-data-lost pull from release 2.3
…d ccfri summary dec to work better checking errrors
… ccfri-4274-closure-data-lost pull from remote
… ccfri-4274-closure-data-lost pull from rel
weskubo-cgi
requested changes
Jan 2, 2025
|
weskubo-cgi
approved these changes
Jan 2, 2025
jenbeckett
added a commit
that referenced
this pull request
Jan 9, 2025
* ecewe org questions show for all applications, expansion panel order changed * fix home page facility cards for orgs with multiple facilities * removed an empty class * ccfri-4307 ecewe status codes incorrect * Ccfri 4274 closure data lost (#606) * fixed bug where date removal was not obeying the index key. Also fixed ccfri summary dec to work better while checking errors * remove unused import * add default font family * Ccfri 4321 rfi UI fix (#609) * UI updates for RFI , fix bug where rows containing dates do not delete properly * fix next button on existing fees correct page * fixed alignment on ul * Ccfri 4247 fix closure table (#611) * when tables open, default them to have one row populated * Ccfri 4362 fix closure table validations (#612) Co-authored-by: weskubo-cgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ccfri 4274 closure data lost
Surprised this bug made it into PROD.. The date pickers were totally broken from the Vue upgrade.
Changed the date pickers to AppDateInput and cleaned up some code.
I also noticed the CCFRI summary dec validation wasn't working great. This should be fixed now and validating properly.
Note: I also noticed than when you have multiple rows of dates, and you delete some index, the row would always clear just the last row, despite some other index being chosen. The rows were set to use index as a key - and this was causing some issues having the date pickers re-render properly. It is fixed here for CCFRI AddNewFees - but I will open a separate PR to fix this in other places because the problem exists elsewhere (RFI as one example)
Types of changes
Checklist
Further comments