fix: race condition to restart printPdf

bcgov · Oct 10, 2024 · 5a3d8eb · 5a3d8eb
1 parent 09cc48e
commit 5a3d8eb
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/backend/src/components/application.js b/backend/src/components/application.js
@@ -504,11 +504,13 @@ async function printPdf(req, numOfRetries = 0) {
 
       await postChangeRequestSummaryDocument(payload);
     }
-
+    browser.close();
     return payload;
   } catch (e) {
     log.error(e);
 
+    if (browser.process() !== null) { await browser.close(); }
+
     if (numOfRetries >= 3) {
       log.info('printPdf :: maximum number of retries reached');
       log.error(`printPdf :: unable to save pdf for application id ${req.params.applicationId}`);
@@ -519,8 +521,6 @@ async function printPdf(req, numOfRetries = 0) {
       log.info(`printPdf :: retry count ${retryCount}`);
       await printPdf(req, retryCount);
     }
-  } finally {
-    await browser.close();
   }
 }