Skip to content

Commit

Permalink
Merge pull request #600 from bcgov/prod-env-fix
Browse files Browse the repository at this point in the history
fix: required banner and banner color in prod
  • Loading branch information
trev-dev authored Dec 12, 2024
2 parents 785f856 + 4115101 commit 40bd652
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/deploy-to-openshift-frontend-prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@ jobs:
-p CERTIFICATE="${{ env.CERTIFICATE }}" \
-p PRIVATE_KEY="${{ env.PRIVATE_KEY }}" \
-p APP_ENVIRONMENT=${{ env.APP_ENVIRONMENT }} \
-p BANNER_COLOR='undefined' \
-p BANNER_ENVIRONMENT='undefined' \
-p VUE_APP_BCEID_REG_URL='${{ secrets.VUE_APP_BCEID_REG_URL }}' \
| oc apply -f -
Expand Down
4 changes: 2 additions & 2 deletions tools/openshift/frontend.deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,10 @@
required: true
- name: BANNER_ENVIRONMENT
description: Environment label for the portal banner
required: true
required: false
- name: BANNER_COLOR
description: The color for the environment label in the portal
required: true
required: false
- name: VUE_APP_BCEID_REG_URL
description: The bceid registration URL
required: true
Expand Down

0 comments on commit 40bd652

Please sign in to comment.