Skip to content

Commit

Permalink
Minor spelling corrections
Browse files Browse the repository at this point in the history
  • Loading branch information
bcgov-hl committed Dec 9, 2023
1 parent 09c3b07 commit eb53b46
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,13 @@
namespace OFM.Infrastructure.CustomWorkflowActivities.Contact
{
public sealed class ValidateContact : CodeActivity
{
{
[Output("Valid")]
public OutArgument<bool> valid { get; set; }

[Output("Validate Message")]
public OutArgument<string> message { get; set; }

protected override void Execute(CodeActivityContext executionContext)
{
ITracingService tracingService = executionContext.GetExtension<ITracingService>();
Expand Down Expand Up @@ -38,10 +44,5 @@ protected override void Execute(CodeActivityContext executionContext)
this.message.Set(executionContext, "a message.");
}

[Output("Valid")]
public OutArgument<bool> valid { get; set; }

[Output("Validate Message")]
public OutArgument<string> message { get; set; }
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@ namespace OFM.Infrastructure.Plugins.Contact
/// Plugin development guide: https://docs.microsoft.com/powerapps/developer/common-data-service/plug-ins
/// Best practices and guidance: https://docs.microsoft.com/powerapps/developer/common-data-service/best-practices/business-logic/
/// </summary>
public class GenerateFacilityPremissions : PluginBase
public class GenerateFacilityPermissions : PluginBase
{
public GenerateFacilityPremissions(string unsecureConfiguration, string secureConfiguration)
: base(typeof(GenerateFacilityPremissions))
public GenerateFacilityPermissions(string unsecureConfiguration, string secureConfiguration)
: base(typeof(GenerateFacilityPermissions))
{
// TODO: Implement your custom configuration handling
// https://docs.microsoft.com/powerapps/developer/common-data-service/register-plug-in#set-configuration-data
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ public class P200EmailReminderProvider : ID365ProcessProvider
private readonly ILogger _logger;
private readonly TimeProvider _timeProvider;
private ProcessData? _data;
private string[] _activeCommunicationTypes = Array.Empty<string>();
private string[] _communicationTypesForUnreadReminders = Array.Empty<string>();
private string[] _activeCommunicationTypes = [];
private string[] _communicationTypesForUnreadReminders = [];
private string _requestUri = string.Empty;

public P200EmailReminderProvider(IOptionsSnapshot<NotificationSettings> notificationSettings, ID365AppUserService appUserService, ID365WebApiService d365WebApiService, ILoggerFactory loggerFactory, TimeProvider timeProvider)
Expand All @@ -48,6 +48,7 @@ public string RequestUri
{
var communicationTypesString = _activeCommunicationTypes.Aggregate((partialPhrase, id) => $"{partialPhrase},{id}");

//for reference only
var fetchXml = $"""
<fetch distinct="true" no-lock="true">
<entity name="email">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ public async Task<JsonObject> RunProcessAsync(ID365AppUserService appUserService
{
recipientsList.Add($"contacts({contact.contactid})");
});

string subject = string.Empty;
string emaildescription = string.Empty;

Expand Down Expand Up @@ -341,7 +342,7 @@ private async Task<ProcessData> GetTemplateToSendEmail()
if (!response.IsSuccessStatusCode)
{
var responseBody = await response.Content.ReadAsStringAsync();
_logger.LogError(CustomLogEvent.Process, "Failed to query Emmail Tempalte to update with the server error {responseBody}", responseBody.CleanLog());
_logger.LogError(CustomLogEvent.Process, "Failed to query Emmail Template to update with the server error {responseBody}", responseBody.CleanLog());

return await Task.FromResult(new ProcessData(string.Empty));
}
Expand Down

0 comments on commit eb53b46

Please sign in to comment.