Skip to content

Commit

Permalink
feat: remove need for quotes around whitelist secret (#129)
Browse files Browse the repository at this point in the history
* feat: remove need for quotes around whitelist secret

* feat: deal with unexpected whitespace in template
  • Loading branch information
trev-dev authored Jun 14, 2024
1 parent 71a9f72 commit dd9f3de
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/deploy-to-openshift-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ jobs:
-p MIN_MEM=${{ env.MIN_MEM }} \
-p MAX_MEM=${{ env.MAX_MEM }} \
-p ENVIRONMENT=${{ env.APP_ENVIRONMENT }} \
-p HAPROXY_IP_WHITELIST=${{ env.HAPROXY_IP_WHITELIST }} \
-p HAPROXY_IP_WHITELIST='${{ env.HAPROXY_IP_WHITELIST }}' \
| oc apply -f -
# Process update-configmap
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-to-openshift-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ jobs:
-p MIN_MEM=${{ env.MIN_MEM }} \
-p MAX_MEM=${{ env.MAX_MEM }} \
-p ENVIRONMENT=${{ env.APP_ENVIRONMENT }} \
-p HAPROXY_IP_WHITELIST=${{ env.HAPROXY_IP_WHITELIST }} \
-p HAPROXY_IP_WHITELIST='${{ env.HAPROXY_IP_WHITELIST }}' \
| oc apply -f -
# Process update-configmap
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-to-openshift-uat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
-p MIN_MEM=${{ env.MIN_MEM }} \
-p MAX_MEM=${{ env.MAX_MEM }} \
-p ENVIRONMENT=${{ env.APP_ENVIRONMENT }} \
-p HAPROXY_IP_WHITELIST=${{ env.HAPROXY_IP_WHITELIST }} \
-p HAPROXY_IP_WHITELIST='${{ env.HAPROXY_IP_WHITELIST }}' \
| oc apply -f -
# Process update-configmap
Expand Down
3 changes: 2 additions & 1 deletion tools/openshift/d365api.dc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,8 @@ objects:
app: '${APP_NAME}-${BRANCH}'
annotations:
openshift.io/host.generated: 'true'
haproxy.router.openshift.io/ip_whitelist: '${HAPROXY_IP_WHITELIST}'
haproxy.router.openshift.io/ip_whitelist: >-
'${HAPROXY_IP_WHITELIST}'
spec:
to:
kind: Service
Expand Down

0 comments on commit dd9f3de

Please sign in to comment.