Skip to content

Commit

Permalink
handle execption code (#196)
Browse files Browse the repository at this point in the history 
* handle exception code

* Add validtion for P405

* Add tracing for Base Funding payments
  • Loading branch information
@RichardInCGI
RichardInCGI authored Jul 25, 2024
1 parent 205133e commit 7729d03
Show file tree
Hide file tree
Showing 3 changed files with 103 additions and 88 deletions.
3 changes: 3 additions & 0 deletions OFM.Infrastructure.WebAPI/Services/Processes/Payments/P505GeneratePaymentLinesProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,8 @@ public async Task<JsonObject> RunProcessAsync(ID365AppUserService appUserService
ArgumentNullException.ThrowIfNull(processParams.Application);
ArgumentNullException.ThrowIfNull(processParams.Application.applicationId);

_logger.LogTrace(CustomLogEvent.Process, "Start processing payments for the funding {FundingId}.", processParams.Funding.FundingId);

_processParams = processParams;

Funding? funding = await _fundingRepository!.GetFundingByIdAsync(new Guid(processParams.Funding!.FundingId!), isPayment: true);
Expand Down Expand Up @@ -366,6 +368,7 @@ public async Task<JsonObject> RunProcessAsync(ID365AppUserService appUserService
break;
}

_logger.LogTrace(CustomLogEvent.Process, "Finished processing payments for the funding {FundingId}.", processParams.Funding.FundingId);

return ProcessResult.Completed(ProcessId).SimpleProcessResult;
}
Expand Down
181 changes: 93 additions & 88 deletions ...frastructure.WebAPI/Services/Processes/ProviderProfiles/P400VerifyGoodStandingProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public class P400VerifyGoodStandingProvider : ID365ProcessProvider
private string? _GScommunicationType;


public P400VerifyGoodStandingProvider(IOptionsSnapshot<ExternalServices> ApiKeyBCRegistry, IOptionsSnapshot<NotificationSettings> notificationSettings , ID365AppUserService appUserService, ID365WebApiService d365WebApiService, ILoggerFactory loggerFactory, TimeProvider timeProvider,IEmailRepository emailRepository)
public P400VerifyGoodStandingProvider(IOptionsSnapshot<ExternalServices> ApiKeyBCRegistry, IOptionsSnapshot<NotificationSettings> notificationSettings, ID365AppUserService appUserService, ID365WebApiService d365WebApiService, ILoggerFactory loggerFactory, TimeProvider timeProvider, IEmailRepository emailRepository)
{
_BCRegistrySettings = ApiKeyBCRegistry.Value.BCRegistryApi;
_NotificationSettings = notificationSettings.Value;
Expand Down Expand Up @@ -359,91 +359,96 @@ public async Task<JsonObject> RunProcessAsync(ID365AppUserService appUserService
_processParams = processParams;

var startTime = _timeProvider.GetTimestamp();
var localData = await GetDataAsync();

var localData = await GetDataAsync();
var deserializedData = JsonSerializer.Deserialize<List<D365Organization_Account>>(localData.Data.ToString());

var deserializedData = JsonSerializer.Deserialize<List<D365Organization_Account>>(localData.Data.ToString());


deserializedData?.Where(c => c.ofm_bypass_bc_registry_good_standing != true).ToList().ForEach(async organization =>
{
string organizationId = organization.accountid;
string legalName = organization.name;
string incorporationNumber = organization.ofm_incorporation_number;
string businessNumber = organization.ofm_business_number;
deserializedData?.Where(c => c.ofm_bypass_bc_registry_good_standing != true).ToList().ForEach(async organization =>
{
string organizationId = organization.accountid;
string legalName = organization.name;
string incorporationNumber = organization.ofm_incorporation_number;
string businessNumber = organization.ofm_business_number;

string? queryValue = (!string.IsNullOrEmpty(incorporationNumber)) ? incorporationNumber.Trim() : legalName.Trim();
string? queryValue = (!string.IsNullOrEmpty(incorporationNumber)) ? incorporationNumber.Trim() : legalName.Trim();

var legalType = "A,B,BC,BEN,C,CC,CCC,CEM,CP,CS,CUL,EPR,FI,FOR,GP,LIC,LIB,LL,LLC,LP,MF,PA,PAR,PFS,QA,QB,QC,QD,QE,REG,RLY,S,SB,SP,T,TMY,ULC,UQA,UQB,UQC,UQD,UQE,XCP,XL,XP,XS";
var status = "active";
var queryString = $"?query=value:{queryValue}::identifier:::bn:::name:" +
$"&categories=legalType:{legalType}::status:{status}";
var legalType = "A,B,BC,BEN,C,CC,CCC,CEM,CP,CS,CUL,EPR,FI,FOR,GP,LIC,LIB,LL,LLC,LP,MF,PA,PAR,PFS,QA,QB,QC,QD,QE,REG,RLY,S,SB,SP,T,TMY,ULC,UQA,UQB,UQC,UQD,UQE,XCP,XL,XP,XS";
var status = "active";
var queryString = $"?query=value:{queryValue}::identifier:::bn:::name:" +
$"&categories=legalType:{legalType}::status:{status}";

var path = $"{_BCRegistrySettings.RegistrySearchUrl}" + $"{queryString}";
var path = $"{_BCRegistrySettings.RegistrySearchUrl}" + $"{queryString}";

var client = new HttpClient();
var request = new HttpRequestMessage(HttpMethod.Get, path);
request.Headers.Add("Account-Id", "1");
request.Headers.Add(_BCRegistrySettings.KeyName, _BCRegistrySettings.KeyValue);
var client = new HttpClient();
var request = new HttpRequestMessage(HttpMethod.Get, path);
request.Headers.Add("Account-Id", "1");
request.Headers.Add(_BCRegistrySettings.KeyName, _BCRegistrySettings.KeyValue);

var response = await client.SendAsync(request);
response.EnsureSuccessStatusCode();
var response = await client.SendAsync(request);

var responseBody = await response.Content.ReadAsStringAsync();
if (response.IsSuccessStatusCode)
{
var responseBody = await response.Content.ReadAsStringAsync();

BCRegistrySearchResult? searchResult = await response.Content.ReadFromJsonAsync<BCRegistrySearchResult>();
BCRegistrySearchResult? searchResult = await response.Content.ReadFromJsonAsync<BCRegistrySearchResult>();

// Organization - Update
var goodStandingStatus = 3; // 1 - Good, 2 - No Good, 3 - Error
// Organization - Update
var goodStandingStatus = 3; // 1 - Good, 2 - No Good, 3 - Error

// Integration Log - Create
var externalService = "BC Registries";
var subject = string.Empty;
var logCategory = 1; // 1 - Info, 2 - Warning, 3 - Error, 4 - Critical
var message = $"{responseBody.CleanLog()}";
// Integration Log - Create
var externalService = "BC Registries";
var subject = string.Empty;
var logCategory = 1; // 1 - Info, 2 - Warning, 3 - Error, 4 - Critical
var message = $"{responseBody.CleanLog()}";

if (searchResult is null || searchResult.searchResults.totalResults < 1)
{
// Todo: Add a new message for this scenario or try seach by name
_logger.LogError(CustomLogEvent.Process, "No results found.");

goodStandingStatus = 3;
logCategory = 3;
subject = "No results found";
await UpdateOrganizationCreateIntegrationLog(_appUserService, _d365webapiservice, organizationId, goodStandingStatus, subject, logCategory, message, externalService);
// return ProcessResult.PartialSuccess(ProcessId, ["No records found."], 0, 0).SimpleProcessResult;
}

if (searchResult.searchResults.totalResults > 1)
{
// ToDo: Process and filter the result further
_logger.LogError(CustomLogEvent.Process, "More than one records returned. Please resolve this issue to ensure uniqueness");

goodStandingStatus = 3;
logCategory = 3;
subject = "Multiple results returned";
await UpdateOrganizationCreateIntegrationLog(_appUserService, _d365webapiservice, organizationId, goodStandingStatus, subject, logCategory, message, externalService);
// return ProcessResult.PartialSuccess(ProcessId, ["Multiple results returned."], 0, 0).SimpleProcessResult;
}
if (searchResult is null || searchResult.searchResults.totalResults < 1)
{
// Todo: Add a new message for this scenario or try seach by name
_logger.LogError(CustomLogEvent.Process, "No results found.");

goodStandingStatus = 3;
logCategory = 3;
subject = "No results found";
await UpdateOrganizationCreateIntegrationLog(_appUserService, _d365webapiservice, organizationId, goodStandingStatus, subject, logCategory, message, externalService);
// return ProcessResult.PartialSuccess(ProcessId, ["No records found."], 0, 0).SimpleProcessResult;
}

if (searchResult.searchResults.totalResults == 1)
{
goodStandingStatus = searchResult.searchResults.results.First().goodStanding ? 1 : 2; // 1 - Good, 2 - No Good, 3 - Error
logCategory = 1; // 1 - Info, 2 - Warning, 3 - Error, 4 - Critical
subject = "One result returned";
await UpdateOrganizationCreateIntegrationLog(_appUserService, _d365webapiservice, organizationId, goodStandingStatus, subject, logCategory, message, externalService);

// Handling Standing History
var goodStandingStatusYN = searchResult.searchResults.results.First().goodStanding ? 1 : 0; // 0 - No, 1 - Yes
await CreateUpdateStandingHistory(_appUserService, _d365webapiservice, organization, goodStandingStatusYN);
if (goodStandingStatusYN == 0) {
await SendNotification(_appUserService, _d365webapiservice, organization,_NotificationSettings);
};
}
if (searchResult.searchResults.totalResults > 1)
{
// ToDo: Process and filter the result further
_logger.LogError(CustomLogEvent.Process, "More than one records returned. Please resolve this issue to ensure uniqueness");

goodStandingStatus = 3;
logCategory = 3;
subject = "Multiple results returned";
await UpdateOrganizationCreateIntegrationLog(_appUserService, _d365webapiservice, organizationId, goodStandingStatus, subject, logCategory, message, externalService);
// return ProcessResult.PartialSuccess(ProcessId, ["Multiple results returned."], 0, 0).SimpleProcessResult;
}

});
if (searchResult.searchResults.totalResults == 1)
{
goodStandingStatus = searchResult.searchResults.results.First().goodStanding ? 1 : 2; // 1 - Good, 2 - No Good, 3 - Error
logCategory = 1; // 1 - Info, 2 - Warning, 3 - Error, 4 - Critical
subject = "One result returned";
await UpdateOrganizationCreateIntegrationLog(_appUserService, _d365webapiservice, organizationId, goodStandingStatus, subject, logCategory, message, externalService);

// Handling Standing History
var goodStandingStatusYN = searchResult.searchResults.results.First().goodStanding ? 1 : 0; // 0 - No, 1 - Yes
await CreateUpdateStandingHistory(_appUserService, _d365webapiservice, organization, goodStandingStatusYN);
if (goodStandingStatusYN == 0)
{
await SendNotification(_appUserService, _d365webapiservice, organization, _NotificationSettings);
};
}
}
else
{
var responseBody = await response.Content.ReadAsStringAsync();
_logger.LogError(CustomLogEvent.Process, "Unable to call BC Registries API with an error {responseBody}.", responseBody.CleanLog());
}
});

return ProcessResult.Completed(ProcessId).SimpleProcessResult;
return ProcessResult.Completed(ProcessId).SimpleProcessResult;
}

private async Task<JsonObject> UpdateOrganizationCreateIntegrationLog(ID365AppUserService appUserService, ID365WebApiService d365WebApiService, string organizationId, int goodStandingStatus, string subject, int category, string message, string externalService)
Expand Down Expand Up @@ -532,13 +537,13 @@ private async Task<JsonObject> CreateUpdateStandingHistory(ID365AppUserService a
if (goodStandingStatusYN == 0) { payload.Add("ofm_no_counter", noduration.Days.ToString()); }
var requestBody = JsonSerializer.Serialize(payload);
var patchResponse = await d365WebApiService.SendPatchRequestAsync(appUserService.AZSystemAppUser, statement, requestBody);

if (goodStandingStatusYN == 0 && noduration.Days >= _BCRegistrySettings.NoDuration)
{ //Handling task creation if rcord is in not good standing fro 90 days
// Tikcet 4631 add condition should have Active Funding
var facilitiesWithActiveFunding = await GetRecordsDataAsync(RecordstoSendNotificationUri);
var deserializedFacilities = JsonSerializer.Deserialize<List<D365Organization_Account>>(facilitiesWithActiveFunding.Data.ToString());
if (deserializedFacilities.Count > 0)
var facilitiesWithActiveFunding = await GetRecordsDataAsync(RecordstoSendNotificationUri);
var deserializedFacilities = JsonSerializer.Deserialize<List<D365Organization_Account>>(facilitiesWithActiveFunding.Data.ToString());
if (deserializedFacilities.Count > 0)
{
await CreateTask(_appUserService, _d365webapiservice, organization, standingHistoryId);
}
Expand Down Expand Up @@ -580,23 +585,23 @@ private async Task<JsonObject> CreateUpdateStandingHistory(ID365AppUserService a
var CreateResponse2 = await d365WebApiService.SendCreateRequestAsync(appUserService.AZSystemAppUser, entitySetName, requestBody2);
}
}

return ProcessResult.Completed(ProcessId).SimpleProcessResult;
}

// Create task if org is in not good standing for more than 90 days
private async Task<JsonObject> CreateTask(ID365AppUserService appUserService, ID365WebApiService d365WebApiService, D365Organization_Account organization,string ofm_standing_historyid)
private async Task<JsonObject> CreateTask(ID365AppUserService appUserService, ID365WebApiService d365WebApiService, D365Organization_Account organization, string ofm_standing_historyid)
{
// _organizationId = organizationId;
_ofm_standing_historyid = ofm_standing_historyid;
var localData = await GetRecordsDataAsync(RecordstoCreateTaskUri);

var deserializedData = JsonSerializer.Deserialize<List<D365StandingHistory>>(localData.Data.ToString());


if (deserializedData.Count <= 0) // Records found
{

// Operation - Create new record
var entitySetName = "tasks"; // Case 3.2 create new record --> open (active)
var assistanceReq = new JsonObject {
Expand All @@ -608,8 +613,8 @@ private async Task<JsonObject> CreateTask(ID365AppUserService appUserService, ID
// create assistance request
var requestBody = JsonSerializer.Serialize(assistanceReq);
var CreateResponse = await d365WebApiService.SendCreateRequestAsync(appUserService.AZSystemAppUser, entitySetName, requestBody);


}

return ProcessResult.Completed(ProcessId).SimpleProcessResult;
Expand All @@ -629,10 +634,10 @@ private async Task<JsonObject> SendNotification(ID365AppUserService appUserServi
IEnumerable<D365CommunicationType> _communicationType = await _emailRepository!.LoadCommunicationTypeAsync();
_GScommunicationType = _communicationType.Where(c => c.ofm_communication_type_number == _NotificationSettings.CommunicationTypes.ActionRequired)
.Select(s => s.ofm_communication_typeid).FirstOrDefault();
var distinctDeserializedData = deserializedData
.GroupBy(g=>g.accountid)
.Select(s=>s.First())
.ToList();
var distinctDeserializedData = deserializedData
.GroupBy(g => g.accountid)
.Select(s => s.First())
.ToList();
var templateData = await _emailRepository.GetTemplateDataAsync(_NotificationSettings.EmailTemplates.First(t => t.TemplateNumber == 400).TemplateNumber);
var serializedtemplateData = JsonSerializer.Deserialize<List<D365Template>>(templateData.Data.ToString());
string? subject = serializedtemplateData?.Select(s => s.title).FirstOrDefault();
Expand All @@ -650,7 +655,7 @@ private async Task<JsonObject> SendNotification(ID365AppUserService appUserServi
recipientsList.Add(new Guid($"{organization?._primarycontactid_value}"));
}

distinctDeserializedData?.Where(c=> c._ofm_primarycontact_value != organization?._primarycontactid_value).ToList().ForEach(recipient =>
distinctDeserializedData?.Where(c => c._ofm_primarycontact_value != organization?._primarycontactid_value).ToList().ForEach(recipient =>
{
if (_notificationSettings.EmailSafeList.Enable &&
!_notificationSettings.EmailSafeList.Recipients.Any(x => x.Equals(recipient.primarycontactemail?.Trim(';'), StringComparison.CurrentCultureIgnoreCase)))
Expand All @@ -663,8 +668,8 @@ private async Task<JsonObject> SendNotification(ID365AppUserService appUserServi
}
});
recipientsList = recipientsList.Distinct().ToList();
await _emailRepository!.CreateAndUpdateEmail(subject, emaildescription, recipientsList,new Guid(_NotificationSettings.DefaultSenderId),_GScommunicationType,appUserService, d365WebApiService, 400);
return ProcessResult.Completed(ProcessId).SimpleProcessResult;
await _emailRepository!.CreateAndUpdateEmail(subject, emaildescription, recipientsList, new Guid(_NotificationSettings.DefaultSenderId), _GScommunicationType, appUserService, d365WebApiService, 400);
return ProcessResult.Completed(ProcessId).SimpleProcessResult;
}


Expand Down
7 changes: 7 additions & 0 deletions ...ructure.WebAPI/Services/Processes/ProviderProfiles/P405VerifyGoodStandingBatchProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,13 @@ private async Task<DateTime> CheckOrganizationGoodStanding(D365Organization_Acco

var response = await httpClient.SendAsync(request);
var responseBody = await response.Content.ReadAsStringAsync();

if (!response.IsSuccessStatusCode)
{
_logger.LogError(CustomLogEvent.Process, "Unable to call BC Registries API with an error {responseBody}.", responseBody.CleanLog());
return await Task.FromResult(DateTime.Now);
}

BCRegistrySearchResult? searchResult = await response.Content.ReadFromJsonAsync<BCRegistrySearchResult>();

// Organization - Update
Expand Down

0 comments on commit 7729d03

Please sign in to comment.