Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined project labels #3296

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: undefined project labels #3296

merged 1 commit into from
May 23, 2024

Conversation

rafasdc
Copy link
Collaborator

@rafasdc rafasdc commented May 22, 2024 •
edited
Loading

adds a condition to check for the existence of the label or title before turning it into a string, otherwise null is returned so the h4 is not rendered. It was causing unintended "undefined" to be shown as labels on conditional approval

Implements [NDT-]

  • Check to trigger automatic release process

@rafasdc rafasdc marked this pull request as ready for review May 22, 2024 23:19
@rafasdc rafasdc requested review from AntBush and RRanath May 22, 2024 23:20
@ccbc-service-account ccbc-service-account force-pushed the fix-undefined-project-labels branch from 98b0322 to a14cb05 Compare May 23, 2024 15:20
@ccbc-service-account ccbc-service-account force-pushed the fix-undefined-project-labels branch from a14cb05 to d132e07 Compare May 23, 2024 15:41
@ccbc-service-account ccbc-service-account force-pushed the fix-undefined-project-labels branch from d132e07 to baa7e93 Compare May 23, 2024 15:56
@ccbc-service-account ccbc-service-account force-pushed the fix-undefined-project-labels branch from 867ec41 to 4a540b9 Compare May 23, 2024 18:22
@ccbc-service-account ccbc-service-account force-pushed the fix-undefined-project-labels branch from 4a540b9 to 6cae47f Compare May 23, 2024 19:45
@rafasdc @ccbc-service-account
fix: undefined project labels
62ea6bd 
adds a condition to check for the existence of the label or title before turning it into a string, otherwise null is return so the h4 is not rendered. It was causing unintended "undefined" to be shown as labels on conditional approval
@ccbc-service-account ccbc-service-account force-pushed the fix-undefined-project-labels branch from 6cae47f to 62ea6bd Compare May 23, 2024 19:59
RRanath
RRanath approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@RRanath RRanath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. 🚀

@rafasdc rafasdc merged commit bf817fc into main May 23, 2024
42 of 43 checks passed
@rafasdc rafasdc deleted the fix-undefined-project-labels branch May 23, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RRanath RRanath RRanath approved these changes

@AntBush AntBush Awaiting requested review from AntBush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafasdc @RRanath @ccbc-service-account