Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump formidable from 2.1.1 to 3.2.4 in /app #3195

Closed
wants to merge 6 commits into from
Closed

chore: bump formidable from 2.1.1 to 3.2.4 in /app #3195

wants to merge 6 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 23, 2024

Bumps formidable from 2.1.1 to 3.2.4.

Release notes

Sourced from formidable's releases.

3.2.4

No release notes provided.

3.1.4

https://github.com/node-formidable/formidable/blob/master/CHANGELOG.md

Changelog

Sourced from formidable's changelog.

3.2.4

  • fix: (#857) improve keep extension
  • The code from before 3.2.4 already removed some characters from the file extension. But not always. So it was inconsistent.
  • The new code cuts the file extension at the first invalid character (invalid in a file extension).
  • The characters that are considered invalid inside a file extension are all except the . numbers and a-Z.
  • This change only has an effect if filename option is not used and keepextension option is used

3.2.3

  • fix: (#852) end event is emitted once

3.2.2

3.2.1

  • fix: do not let empty file on error (#796)
  • it was probably due to the fact that .destroy on a file stream does not always complete on time

3.2.0

  • feat: maxFileSize option is now per file (as the name suggests) (#791)
  • feat: add maxFiles option, default Infinity
  • feat: add maxTotalFileSize, default is maxFileSize (for backwards compatibility)
  • fix: minFileSize is per file
  • fix: allowEmptyFiles fix in cases where one file is not empty
  • fix: allowEmptyFiles false option by default
  • fix: rename wrongly named error
  • refactor: rename wrongly named maxFileSize into maxTotalFileSize

3.1.5

  • fix: PersistentFile.toString (#796)

3.1.4

  • fix: add missing pluginFailed error (#794)
  • refactor: use explicit node imports (#786)

3.1.1

  • feat: handle top level json array, string and number

3.1.0

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Apr 23, 2024
@AntBush AntBush force-pushed the dependabot/npm_and_yarn/app/formidable-3.2.4 branch from c6dd43e to f1462dc Compare April 24, 2024 19:06
@AntBush AntBush enabled auto-merge April 24, 2024 19:07
AntBush
AntBush previously approved these changes Apr 24, 2024
View reviewed changes
@AntBush AntBush disabled auto-merge April 24, 2024 19:07
@AntBush AntBush self-requested a review April 24, 2024 19:34
@AntBush AntBush dismissed their stale review April 24, 2024 19:34

not working as expected

@AntBush AntBush force-pushed the dependabot/npm_and_yarn/app/formidable-3.2.4 branch from 3706127 to 254564f Compare April 26, 2024 20:21
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 26, 2024
View reviewed changes
app/backend/lib/gis-upload.ts Outdated
@@ -76,22 +75,25 @@
if (!isRoleAuthorized) {
return res.status(404).end();
}
const form = new formidable.IncomingForm({ maxFileSize: 8000000 });

const form = formidable({ maxFileSize: 8000000 });

Check failure

Code scanning / SonarCloud

File uploads should be restricted

<!--SONAR_ISSUE_KEY:AY8cGQoLx5pQrkL5DKPY-->Restrict folder destination of uploaded files. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_CONN-CCBC-portal&issues=AY8cGQoLx5pQrkL5DKPY&open=AY8cGQoLx5pQrkL5DKPY&pullRequest=3195">SonarCloud</a></p>
app/backend/lib/claims-upload.ts Outdated
@@ -24,15 +24,18 @@
}

const errorList = [];
const form = new formidable.IncomingForm({ maxFileSize: 8000000 });
const form = formidable({ maxFileSize: 8000000 });

Check failure

Code scanning / SonarCloud

File uploads should be restricted

<!--SONAR_ISSUE_KEY:AY8cGQp9x5pQrkL5DKPa-->Restrict folder destination of uploaded files. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_CONN-CCBC-portal&issues=AY8cGQp9x5pQrkL5DKPa&open=AY8cGQp9x5pQrkL5DKPa&pullRequest=3195">SonarCloud</a></p>
app/backend/lib/sow-upload.ts Outdated
@@ -28,15 +28,17 @@
}

const errorList = [];
const form = new formidable.IncomingForm({ maxFileSize: 8000000 });
const form = formidable({ maxFileSize: 8000000 });

Check failure

Code scanning / SonarCloud

File uploads should be restricted

<!--SONAR_ISSUE_KEY:AY8cGQpmx5pQrkL5DKPZ-->Restrict folder destination of uploaded files. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_CONN-CCBC-portal&issues=AY8cGQpmx5pQrkL5DKPZ&open=AY8cGQpmx5pQrkL5DKPZ&pullRequest=3195">SonarCloud</a></p>
app/backend/lib/milestone-upload.ts Outdated
@@ -24,15 +24,18 @@
}

const errorList = [];
const form = new formidable.IncomingForm({ maxFileSize: 8000000 });
const form = formidable({ maxFileSize: 8000000 });

Check failure

Code scanning / SonarCloud

File uploads should be restricted

<!--SONAR_ISSUE_KEY:AY8cGQqhx5pQrkL5DKPd-->Restrict folder destination of uploaded files. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_CONN-CCBC-portal&issues=AY8cGQqhx5pQrkL5DKPd&open=AY8cGQqhx5pQrkL5DKPd&pullRequest=3195">SonarCloud</a></p>
app/backend/lib/template-upload.ts Outdated
@@ -28,15 +28,17 @@
}

const errorList = [];
const form = new formidable.IncomingForm({ maxFileSize: 8000000 });
const form = formidable({ maxFileSize: 8000000 });

Check failure

Code scanning / SonarCloud

File uploads should be restricted

<!--SONAR_ISSUE_KEY:AY8cGQqJx5pQrkL5DKPb-->Restrict folder destination of uploaded files. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_CONN-CCBC-portal&issues=AY8cGQqJx5pQrkL5DKPb&open=AY8cGQqJx5pQrkL5DKPb&pullRequest=3195">SonarCloud</a></p>
app/backend/lib/community-report-upload.ts Outdated
@@ -22,15 +22,17 @@
}

const errorList = [];
const form = new formidable.IncomingForm({ maxFileSize: 8000000 });
const form = formidable({ maxFileSize: 8000000 });

Check failure

Code scanning / SonarCloud

File uploads should be restricted

<!--SONAR_ISSUE_KEY:AY8cGQqVx5pQrkL5DKPc-->Restrict folder destination of uploaded files. <p>See more on <a href="https://sonarcloud.io/project/issues?id=bcgov_CONN-CCBC-portal&issues=AY8cGQqVx5pQrkL5DKPc&open=AY8cGQqVx5pQrkL5DKPc&pullRequest=3195">SonarCloud</a></p>
@ccbc-service-account ccbc-service-account force-pushed the dependabot/npm_and_yarn/app/formidable-3.2.4 branch from 254564f to 143c9b9 Compare April 26, 2024 20:36
@ccbc-service-account ccbc-service-account force-pushed the dependabot/npm_and_yarn/app/formidable-3.2.4 branch from 07bc11d to 4cefa6e Compare May 8, 2024 14:33
@ccbc-service-account ccbc-service-account force-pushed the dependabot/npm_and_yarn/app/formidable-3.2.4 branch from 4cefa6e to 029cd34 Compare May 8, 2024 14:48
dependabot bot and others added 6 commits May 8, 2024 15:10
@ccbc-service-account ccbc-service-account force-pushed the dependabot/npm_and_yarn/app/formidable-3.2.4 branch from 029cd34 to 9dbd617 Compare May 8, 2024 15:10
@rafasdc rafasdc closed this May 15, 2024
@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github May 15, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/npm_and_yarn/app/formidable-3.2.4 branch May 15, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AntBush AntBush Awaiting requested review from AntBush

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AntBush @rafasdc @ccbc-service-account