fix: legacy broker account features (#290)

bcgov-nr · Dec 24, 2024 · f0c7759 · f0c7759
1 parent ae49b49
commit f0c7759
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/src/intention/action.service.ts b/src/intention/action.service.ts
@@ -104,10 +104,10 @@ export class ActionService {
         data: {
           action: action.action,
           action_id: action.id,
-          key: action.service.target.environment
+          key: action.service.target?.environment
             ? 'action.service.target.environment'
             : 'action.service.environment',
-          value: action.service.target.environment
+          value: action.service.target?.environment
             ? action.service.target.environment
             : action.service.environment,
         },

diff --git a/src/intention/intention-util.service.ts b/src/intention/intention-util.service.ts
@@ -31,6 +31,12 @@ export class IntentionUtilService {
       return UserEmbeddable.fromUserEntity(userEntity, accountEntity);
     }
 
+    if (accountEntity.skipUserValidation) {
+      const embeddable = new UserEmbeddable();
+      embeddable.name = user.name;
+      return embeddable;
+    }
+
     throw new Error('User not found.');
   }
 }
diff --git a/src/intention/intention.service.ts b/src/intention/intention.service.ts
@@ -197,9 +197,7 @@ export class IntentionService {
           serviceEmbed.id = service._id;
         }
         const trace = TransactionEmbeddable.create();
-        const vaultEnvironment =
-          ENVIRONMENT_NAMES[this.computeVaultEnvironment(action, envMap)];
-
+        const vaultEnvironment = this.computeVaultEnvironment(action, envMap);
         switch (action.action) {
           case ACTION_NAMES.BACKUP:
             return new BackupActionEmbeddable(
@@ -898,7 +896,7 @@ export class IntentionService {
   private computeVaultEnvironment(
     action: ActionEmbeddable | ActionDto,
     envMap: EnvironmentEntityMap,
-  ) {
+  ): ENVIRONMENT_NAMES {
     const env = this.actionUtil.environmentName(action);
     const envDto = envMap[env];
     if (

diff --git a/src/persistence/entity/environment.entity.ts b/src/persistence/entity/environment.entity.ts
@@ -9,6 +9,7 @@ import { ObjectId } from 'mongodb';
 import { ApiHideProperty } from '@nestjs/swagger';
 import { VertexPointerEntity } from './vertex-pointer.entity';
 import { COLLECTION_COLLATION_LOCALE } from '../../constants';
+import { ENVIRONMENT_NAMES } from '../../intention/dto/constants.dto';
 
 @Entity({ tableName: 'environment' })
 export class EnvironmentEntity extends VertexPointerEntity {
@@ -22,7 +23,7 @@ export class EnvironmentEntity extends VertexPointerEntity {
 
   @Property()
   @Index({ options: { collation: { locale: COLLECTION_COLLATION_LOCALE } } })
-  name: string;
+  name: ENVIRONMENT_NAMES;
 
   @Property()
   short: string;