Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAM1-1436 & WSTEAM1-1437: Gahuza footer updates for .lite launch #12161

Merged
merged 5 commits into from
Nov 12, 2024

Conversation

Isabella-Mitchell
Copy link
Contributor

@Isabella-Mitchell Isabella-Mitchell commented Nov 12, 2024

Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAM1-1436 & https://jira.dev.bbc.co.uk/browse/WSTEAM1-1437

Overall changes

  • Add .lite override to 'get news in your language' footer link for soft launch
  • Update Gahuza Footer link for "Other Languages" to include marketing query string

Code changes

  • Updates Gahuza config & snapshots
  • Adds isRestrictedOnSoftLaunch check to litePageTransforms/transformAnchorTags

Testing

Run locally
1)
visit http://localhost:7080/gahuza?renderer_env=live
Check the footer link for 'Bona amakuru mu zindi ndimi'
Check it goes to 'https://www.bbc.com/ws/languages?xtor=CS1-13-[wsgahuza~N~A39~MBC]-[Owned]&utm_source=mktg'
2)
visit http://localhost:7080/gahuza.lite?renderer_env=live
Check the footer link for 'Bona amakuru mu zindi ndimi'
Check it goes to 'https://www.bbc.com/ws/languages?xtor=CS1-13-[wsgahuza~N~A39~MBC]-[Owned]&utm_source=mktg'
(Note no .lite extension)

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Isabella-Mitchell Isabella-Mitchell marked this pull request as ready for review November 12, 2024 09:53
@amoore108
Copy link
Contributor

amoore108 commented Nov 12, 2024

Looks good. Just curious is there a reason why we're not supporting the /ws/languages page on Lite? Or is that happening post soft launch?

Should just be a case of adding the route in Belfrage and then setting the isLite flag in the /ws/languages getServerSideProps.

@Isabella-Mitchell
Copy link
Contributor Author

Looks good. Just curious is there a reason why we're not supporting the /ws/languages page on Lite? Or is that happening post soft launch?

Should just be a case of adding the route in Belfrage and then setting the isLite flag in the /ws/languages getServerSideProps.

We figured if someone did successfully visit 'https://www.bbc.com/ws/languages.lite' then they would expect the links to take them to other services on .lite. We want to limit the "soft launch experience" to Gahuza. So by not permitting the .lite extension we're managing user expectation & making it less easy for them to access other services on .lite.

@amoore108
Copy link
Contributor

Looks good. Just curious is there a reason why we're not supporting the /ws/languages page on Lite? Or is that happening post soft launch?
Should just be a case of adding the route in Belfrage and then setting the isLite flag in the /ws/languages getServerSideProps.

We figured if someone did successfully visit 'https://www.bbc.com/ws/languages.lite' then they would expect the links to take them to other services on .lite. We want to limit the "soft launch experience" to Gahuza. So by not permitting the .lite extension we're managing user expectation & making it less easy for them to access other services on .lite.

Ah fair point. Makes sense, something we can tackle later with the full roll out 👍

@Isabella-Mitchell Isabella-Mitchell merged commit 3886369 into latest Nov 12, 2024
11 checks passed
@Isabella-Mitchell Isabella-Mitchell deleted the WSTEAM1-1436-languages-footer-link branch November 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants