-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAM1-1436 & WSTEAM1-1437: Gahuza footer updates for .lite launch #12161
Conversation
Looks good. Just curious is there a reason why we're not supporting the Should just be a case of adding the route in Belfrage and then setting the |
We figured if someone did successfully visit 'https://www.bbc.com/ws/languages.lite' then they would expect the links to take them to other services on .lite. We want to limit the "soft launch experience" to Gahuza. So by not permitting the .lite extension we're managing user expectation & making it less easy for them to access other services on .lite. |
Ah fair point. Makes sense, something we can tackle later with the full roll out 👍 |
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAM1-1436 & https://jira.dev.bbc.co.uk/browse/WSTEAM1-1437
Overall changes
Code changes
Testing
Run locally
1)
visit http://localhost:7080/gahuza?renderer_env=live
Check the footer link for 'Bona amakuru mu zindi ndimi'
Check it goes to 'https://www.bbc.com/ws/languages?xtor=CS1-13-[wsgahuza~N~A39~MBC]-[Owned]&utm_source=mktg'
2)
visit http://localhost:7080/gahuza.lite?renderer_env=live
Check the footer link for 'Bona amakuru mu zindi ndimi'
Check it goes to 'https://www.bbc.com/ws/languages?xtor=CS1-13-[wsgahuza~N~A39~MBC]-[Owned]&utm_source=mktg'
(Note no .lite extension)
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines