-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WSTEAMA 1315 - Move logic that creates SMP settings object in Simorgh #11866
Merged
Nabeel1276
merged 64 commits into
latest
from
WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
Sep 2, 2024
Merged
WSTEAMA 1315 - Move logic that creates SMP settings object in Simorgh #11866
Nabeel1276
merged 64 commits into
latest
from
WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
Sep 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-in-Simorgh' of https://github.com/bbc/simorgh into WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
…ettings-object-in-Simorgh
…ettings-object-in-Simorgh
…ettings-object-in-Simorgh
…ettings-object-in-Simorgh
…t-in-Simorgh' of https://github.com/bbc/simorgh into WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
…/simorgh into WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
amoore108
reviewed
Aug 28, 2024
…ettings-object-in-Simorgh
…t-in-Simorgh' of https://github.com/bbc/simorgh into WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
Nabeel1276
force-pushed
the
WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
branch
from
August 29, 2024 10:27
18832ea
to
e2c1ba8
Compare
…ettings-object-in-Simorgh
…t-in-Simorgh' of https://github.com/bbc/simorgh into WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
…t-in-Simorgh' of https://github.com/bbc/simorgh into WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
amoore108
reviewed
Aug 29, 2024
alex-magana
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
…ettings-object-in-Simorgh
amoore108
approved these changes
Aug 30, 2024
Nabeel1276
deleted the
WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh
branch
September 2, 2024 08:07
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JIRA - https://jira.dev.bbc.co.uk/browse/WSTEAMA-1315
Overall changes
Code changes
Testing
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines