Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSTEAMA 1315 - Move logic that creates SMP settings object in Simorgh #11866

Conversation

holchris
Copy link
Contributor

@holchris holchris commented Aug 19, 2024

Resolves JIRA - https://jira.dev.bbc.co.uk/browse/WSTEAMA-1315

Overall changes

Code changes

  • Testing for Media Loader On Demand TV
  • Update Hindi TV Programme fixture data
  • Create tvMedia config
  • Refactor MediaLoader config

Testing

  1. List the steps used to test this PR.

Helpful Links

Add Links to useful resources related to this PR if applicable.

Coding Standards

Repository use guidelines

@Nabeel1276 Nabeel1276 force-pushed the WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh branch from 18832ea to e2c1ba8 Compare August 29, 2024 10:27
Copy link
Contributor

@alex-magana alex-magana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@Nabeel1276 Nabeel1276 merged commit 4c3b294 into latest Sep 2, 2024
11 checks passed
@Nabeel1276 Nabeel1276 deleted the WSTEAMA-1315-move-logic-that-creates-SMP-settings-object-in-Simorgh branch September 2, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants