-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate cache-control
for av-embeds
routes
#11852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tried to test locally but I didn't see the expected results. However I'm not sure whether this is the right place, or we would expect to see this locally.
(I compared cache control of the document in the network tab for a live Morph asset and a local asset whilst running this branch).
Yea Next.js overrides the cache-control header when running locally/development mode so that hot-reloading / code change works correctly. Think it sets it to something like |
Nice, yep that worked! Will note that one down for next time 🙌 |
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WSTEAM1-1237
Overall changes
cache-control
header from Morph for Syndication and non-Syndication routesTesting
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines