Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If authFile is missing, try to use the user's default .netrc file (~/.netrc) #387

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

grepwood
Copy link

@grepwood grepwood commented Sep 3, 2024

I have come across this problem at work and I needed to be able to generate a workspace.bzl that includes some kind of way to read my .netrc file without specifying a path to it in the authFile parameter, because this will never ever be the same constant path on developer workstations and our CICD.

This PR sums up the necessary changes in order for bazel-deps to be able to do that.

Just to be clear:

  • the authFile support in dependencies.yaml is not going away, it's still the dominant setting
  • in absence of authFile, _get_auth() will try to get the contents of ~/.netrc or if it doesn't exist return an empty dictionary

Also, this is my first time writing Scala code. Please please please please please tell me if I wrote the assembly of jarArtifactImpl with the variable part in between correctly.

…did not specify an authFile, we will generate code that still attempts to read the user's personal .netrc file from their home directory
@bartoszkosiorek
Copy link

@non Do you know who could take a look at this review?
It is resolving my long standing issue with authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants