Avoid racing in fake package #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetFlattenedOutputs() takes the pointer of ec.resPb, and forward it to a long-running grpc call. This will cause racing to happen in re-client unit test framework. See this one line change in re-client that face racing issue: tg/2184373 This change avoid the racing issue by make a deepcopy of resPb before forward it to grpc call. Test: import to re-client and run //internal/pkg/reproxy:reproxy_test with race detection.
GetFlattenedOutputs() takes the pointer of ec.resPb, and forward it to a long-running grpc call. This will cause racing to happen in re-client unit test framework. See this one line change in re-client that face racing issue: tg/2184373 This change avoid the racing issue by make a deepcopy of resPb before forward it to grpc call. Test: import to re-client and run //internal/pkg/reproxy:reproxy_test with race detection.
re-client `reproxy_test` unit test has been having racing issue for long time, this change fix the data racing issue there and make most of the unit test there can run with t.parallel() Test: import to re-client and run //internal/pkg/reproxy:reproxy_test with race detection.
ywmei-brt1
changed the title
mrahs
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid racing in fake
re-client
reproxy_testunit test has been suffering racing issues for long time,This change will fix the data racing issue, and make most of the unit test there can run with t.parallel()
Test: import to re-client and run //internal/pkg/reproxy:reproxy_test with race detection.