fix preserving intermediate symlinks #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkousik
reviewed
Nov 8, 2023
gkousik
reviewed
Nov 8, 2023
gkousik
approved these changes
Nov 13, 2023
This patch handles virtual inputs. The code that handles virtual inputs skips loadFiles entirely which effectively skips the previous patches. This patch removes the redundant map by leveraging the existing one, fs. The tradeoff is less allocation from the removed map, but more calls to filepath.Rel and filepath.Join to get the key for the existing map. Tested on a relevant action locally and confirmed it succeeds. Also ran a full build with no issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch handles virtual inputs. The code that handles virtual inputs skips loadFiles entirely which effectively skips the previous patches.
This patch removes the redundant map by leveraging the existing one, fs. The tradeoff is less allocation from the removed map, but more calls to filepath.Rel and filepath.Join to get the key for the existing map.
Tested on a relevant action locally and confirmed it succeeds. Also ran a full build with no issues.