Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save show_action result while download action #523

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

ywmei-brt1
Copy link
Collaborator

Test:Manual Test

@mrahs mrahs self-requested a review November 7, 2023 14:29
@mrahs
Copy link
Collaborator

mrahs commented Nov 8, 2023

The data ShowAction fetches and prints is already downloaded. The user can cat the same information from files without having to call the server twice. Wouldn't that achieve what this PR is trying to do?

@ywmei-brt1 ywmei-brt1 force-pushed the save_show_action branch 2 times, most recently from d63c9b0 to 6badb6a Compare November 8, 2023 23:07
Reusing show_action logic inside of download_action.

Test:Manual Test
Copy link
Collaborator

@mrahs mrahs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This patch looks much better.

go/pkg/tool/tool.go Outdated Show resolved Hide resolved
go/pkg/tool/tool.go Outdated Show resolved Hide resolved
go/pkg/tool/tool.go Outdated Show resolved Hide resolved
go/pkg/tool/tool.go Outdated Show resolved Hide resolved
@mrahs mrahs merged commit 8e484d7 into bazelbuild:master Nov 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants