Skip to content

Commit

Permalink
Fixed and renovated Rust example 08 grpc. (#492)
Browse files Browse the repository at this point in the history
Fixed and renovaeted rust-examples/08-grpc-client-server/
Resolves:
#489 (comment)

The CI failure of the example was caused by a bizarre issue that only
occurs on linux, as documented
bazelbuild/rules_rust#2806

I've applied the known fix. Furthermore, the cause of the issue seems to
be a change in the format of how aliases
are generated for downloaded dependencies referenced in the example. To
prevent this from ever happening again, I've vendored all dependencies
and updated the Bazel build files accordingly.

---------

Signed-off-by: Marvin Hansen <[email protected]>
  • Loading branch information
marvin-hansen authored Sep 10, 2024
1 parent f1f1cb6 commit 922300e
Show file tree
Hide file tree
Showing 148 changed files with 16,750 additions and 2,107 deletions.
15 changes: 7 additions & 8 deletions .bazelci/tutorial-rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,18 @@ tasks:
working_directory: ../rust-examples/07-deps-vendor
build_targets:
- "//..."
# TODO: Renable after addressing https://github.com/bazelbuild/examples/pull/489#issuecomment-2321617323
# rust-08-grpc-client-server-linux:
# name: "Rust grpc"
# platform: ubuntu2204
# working_directory: ../rust-examples/08-grpc-client-server
# build_targets:
# - "//:all"
rust-08-grpc-client-server-linux:
name: "Rust grpc"
platform: ubuntu2204
working_directory: ../rust-examples/08-grpc-client-server
build_targets:
- "//..."
rust-08-grpc-client-server-macos:
name: "Rust grpc"
platform: macos_arm64
working_directory: ../rust-examples/08-grpc-client-server
build_targets:
- "//:all"
- "//..."
rust-09-oci-container-linux:
name: "Rust OCI"
platform: ubuntu2204
Expand Down
8 changes: 0 additions & 8 deletions rust-examples/08-grpc-client-server/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,3 @@ config_setting(
"compilation_mode": "opt",
},
)

filegroup(
name = "all",
srcs = [
"//grpc_client:bin",
"//grpc_server:bin",
],
)
Loading

0 comments on commit 922300e

Please sign in to comment.