Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update java_tools v13.14 / rules_java 8.7.0 #24696

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Update java_tools v13.14 / rules_java 8.7.0 #24696

wants to merge 11 commits into from
+215 −419

Conversation

iancha1992
Copy link
Member

@iancha1992 iancha1992 requested a review from hvadehra December 13, 2024 23:39
@iancha1992 iancha1992 mentioned this pull request Dec 13, 2024
Open
@iancha1992
Copy link
Member Author

@hvadehra Can you please take a look at the presubmit errors? Thanks!

@hvadehra
Copy link
Member

hvadehra commented Dec 16, 2024 •
edited
Loading

CI still seems to be running with Bazel 7. Can you first sync this branch with HEAD?

@iancha1992
Copy link
Member Author

CI still seems to be running with Bazel 7. Can you first sync this branch with HEAD?

@hvadehra
I did, but it's still failing. Is it because we've rolled the .bazelversion back in 16f08cb?

@hvadehra
Copy link
Member

hvadehra commented Dec 18, 2024 •
edited
Loading

From the failure it looks like you may have updated the lock files with Bazel 8. Try updating the lock files again with Bazel 7.4.1?

(we might be running into bazelbuild/bazelisk#52 now that we no longer have a WORKSPACE file in Bazel, cc @meteorcloudy )

@iancha1992 iancha1992 marked this pull request as ready for review December 20, 2024 00:00
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Dec 20, 2024
@iancha1992 iancha1992 marked this pull request as draft December 20, 2024 00:59
@iancha1992
Copy link
Member Author

Hi @hvadehra. Looks like there's another presubmit error after updating the lockfile on 7.4.1. Could you please take a look? Thanks!

@iancha1992 iancha1992 added the team-Rules-Java Issues for Java rules label Dec 20, 2024
@hvadehra
Copy link
Member

hvadehra commented Jan 7, 2025

Hi @hvadehra. Looks like there's another presubmit error after updating the lockfile on 7.4.1. Could you please take a look? Thanks!

Let's wait for cl/712656125, hopefully that will fix it.

@hvadehra
Copy link
Member

hvadehra commented Jan 8, 2025

Hi @hvadehra. Looks like there's another presubmit error after updating the lockfile on 7.4.1. Could you please take a look? Thanks!

Let's wait for cl/712656125, hopefully that will fix it.

That went in as 2a34ae2, lets rebase this on HEAD?

@iancha1992 iancha1992 force-pushed the java_tools-v13.14 branch 2 times, most recently from 33975e7 to cb8cb86 Compare January 8, 2025 23:07
@iancha1992
Copy link
Member Author

iancha1992 commented Jan 9, 2025 •
edited
Loading

Hi @hvadehra. Looks like there's another presubmit error after updating the lockfile on 7.4.1. Could you please take a look? Thanks!

Let's wait for cl/712656125, hopefully that will fix it.

That went in as 2a34ae2, lets rebase this on HEAD?

heec@ianc:~/bazel$ bazel mod deps --lockfile_mode=update

DEBUG: /usr/local/google/home/heec/.cache/bazel/_bazel_heec/3029c92a619cd69b9154652fa5352d1e/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'bazel' and now in 'grpc-java'
DEBUG: /usr/local/google/home/heec/.cache/bazel/_bazel_heec/3029c92a619cd69b9154652fa5352d1e/external/rules_jvm_external+/private/extensions/maven.bzl:155:14: The maven repository 'maven' is used in two different bazel modules, originally in 'bazel' and now in 'protobuf'
<root> ([email protected])

@hvadehra
I am getting this error when I try to update the lockfile after rebasing :(

@fmeum
Copy link
Collaborator

fmeum commented Jan 9, 2025

Those warnings can safely be ignored. Looks like the command passed.

@hvadehra
Copy link
Member

hvadehra commented Jan 9, 2025

The CI failures looks like a re-occurrence of #24696 (comment)

@hvadehra hvadehra mentioned this pull request Jan 9, 2025
Closed
@iancha1992 iancha1992 marked this pull request as ready for review January 9, 2025 22:01
@iancha1992
Copy link
Member Author

iancha1992 commented Jan 9, 2025 •
edited
Loading

The CI failures looks like a re-occurrence of #24696 (comment)

@hvadehra My bad... I forgot about that. Looks like it's passing now

@iancha1992 iancha1992 marked this pull request as draft January 9, 2025 22:16
@hvadehra
Copy link
Member

LGTM, lets make the java_tools final release & update in rules_java.

@iancha1992
Copy link
Member Author

I'll update the lockfiles tomorrow...

@iancha1992 iancha1992 marked this pull request as ready for review January 15, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvadehra hvadehra Awaiting requested review from hvadehra

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Rules-Java Issues for Java rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iancha1992 @hvadehra @fmeum @Wyverald