Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update java_export.bzl docs #1158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michaelschuett-tomtom
Copy link

Fix docs to correctly use no-javadocs instead of no-javadoc which does not work.

Copy link

google-cla bot commented Jun 4, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@shs96c
Copy link
Collaborator

shs96c commented Jun 4, 2024

This looks great. Thank you for the PR and updating the docs. Could you also please run ./scripts/generate_docs.sh to make sure that the api reference is also updated?

Fix docs to correctly use no-javadocs instead of no-javadoc which does not work.
@michaelschuett-tomtom
Copy link
Author

hmm i imagine I should see a few more change but this was the output from running that script.

(base) schuettm@MAC-LP7FQ66X7J rules_jvm_external % ./scripts/generate_docs.sh                                                                                       
INFO: Analyzed target //scripts:generate_api_reference (68 packages loaded, 2942 targets configured).
INFO: Found 1 target...
Target //scripts:generate_api_reference up-to-date:
  bazel-bin/scripts/api.md
INFO: Elapsed time: 21.987s, Critical Path: 5.29s
INFO: 23 processes: 13 internal, 7 darwin-sandbox, 3 worker.
INFO: Build completed successfully, 23 total actions

@shs96c
Copy link
Collaborator

shs96c commented Jun 7, 2024

Thank you for running that. I think that only thing that's left is get the CLA signed, and then I'm more than happy to merge this!

@shs96c
Copy link
Collaborator

shs96c commented Sep 7, 2024

Would you like us to look at this PR again? Do you need a hand getting the CLA signed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants