feat(mode): add `purego` tag when `pure` #3901

mattyclarkson · 2024-03-22T13:16:11Z

The community has agreed1 that "pure" builds of Go code should use the purego build tag.

This change adds that de-facto tag.

Spun out from bazelbuild/bazel-central-registry#1629 to solve building of circl.

go/private/mode.bzl

mattyclarkson · 2024-03-26T13:39:04Z

For what it's worth: this works with cloudflare/circl#492

mattyclarkson · 2024-04-06T16:20:10Z

This branch updates Gazelle to 0.36.0 to get the purego patch.

The Bazel 6.0.0 CI states:

Error computing the main repository mapping: The MODULE.bazel file of [email protected] declares overrides

That would come from the single_version_override that is in the Gazelle release.

I can reproduce that locally:

$ USE_BAZEL_VERSION=6.0.0 bazelisk build --announce_rc -- //...
Starting local Bazel server and connecting to it...
INFO: Options provided by the client:
  Inherited 'common' options: --isatty=1 --terminal_columns=190
INFO: Reading rc options for 'build' from /home/matt-clarkson/git/github/bazelbuild/rules_go/tests/bcr/.bazelrc:
  Inherited 'common' options: --enable_bzlmod
ERROR: Error computing the main repository mapping: The MODULE.bazel file of [email protected] declares overrides

That is a a bug with Bazel 6.0.0, 6.1.0, 6.2.0. Fixed in 6.3.0. We may have to update to 6.3.0 in the CI.

FYI: @tyler-french, @fmeum

fmeum · 2024-04-06T17:22:34Z

I think it's fine to require 6.3.0+ and make the according change to CI. Minor updates are assumed to be backwards compatible anyway.

mattyclarkson · 2024-04-06T17:40:06Z

OK. Updated to 6.3.0. All green on CI 🎉

fmeum · 2024-04-06T20:27:45Z

@mattyclarkson Thanks!

@tyler-french Could you test this on the Über codebase?

mattyclarkson · 2024-05-07T10:28:48Z

@tyler-french / @fmeum if you have time in the next release cycle: it'd be great to get this in. It would allow cloudflare/circl#492 to build without modification to the generated Gazelle build files (and possibly other modules). Thanks.

The community has agreed[1] that "pure" builds of Go code should use the `purego` build tag. This change adds that de-facto tag. The minimum version of Gazelle is bumped to `0.36.0` which includes a patch[2] for ignoring the `purego` tag so that the source flies are passed to the compiler for conditional compilation decisions. [1]: golang/go#23172 [2]: bazel-contrib/bazel-gazelle#1767

tyler-french · 2024-05-07T21:29:15Z

@tyler-french / @fmeum if you have time in the next release cycle: it'd be great to get this in. It would allow cloudflare/circl#492 to build without modification to the generated Gazelle build files (and possibly other modules). Thanks.

Yes. I was blocked on something else but I will get this tested this week.

tyler-french · 2024-05-08T15:11:43Z

I tested this and its compatible with all existing rules, but I'm trying to remove patches from github.com/cloudflare/circl that add the cgo tags and export the .h files and it's failing.

Are there other changes needed to fix this build?

tyler-french

Tested at Uber

mattyclarkson · 2024-05-08T16:07:27Z

I tested this and its compatible with all existing rules, but I'm trying to remove patches from github.com/cloudflare/circl that add the cgo tags and export the .h files and it's failing.

Are there other changes needed to fix this build?

You need cloudflare/circl#492 which switches all their build tags to purego. That is in [email protected].

Gazelle learnt to understand purego tags in bazel-contrib/bazel-gazelle#1767 which is in [email protected].

With those two things and this patch, you should be able to generate working build files direcly with Gazelle.

If you have a Go module that depends on cloudflare/circl in go.mod and are using the Gazelle extension, upgrading to 1.3.8 should make everything work.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.47.1` -> `v0.48.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.48.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.1...v0.48.0) #### Important Changes! `--incompatible_enable_proto_toolchain_resolution` is now supported in `rules_go`. This means that protoc should now be supplied as a toolchain. `protoc` can be registered using https://github.com/aspect-build/toolchains_protoc, or a local proto toolchain can be added. #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "33acc4ae0f70502db4b893c9fc1dd7a9bf998c23e7ff2c4517741d4049a976f8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.3") #### What's Changed - Update docs to cover new FilePath ReplaceDirective Support by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) - go_test: use different mnemonic for compilation by [@sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3936](https://togithub.com/bazelbuild/rules_go/pull/3936) - Add go.work support to the documentation by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3932](https://togithub.com/bazelbuild/rules_go/pull/3932) - feat(mode): add `purego` tag when `pure` by [@mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3901](https://togithub.com/bazelbuild/rules_go/pull/3901) - generate_test_main: Move timeout handling back to bzltestutil by [@DolceTriade](https://togithub.com/DolceTriade) in [https://github.com/bazelbuild/rules_go/pull/3939](https://togithub.com/bazelbuild/rules_go/pull/3939) - Add support for `--incompatible_enable_proto_toolchain_resolution` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3919](https://togithub.com/bazelbuild/rules_go/pull/3919) - Add exec_compatible_with to @go_sdk//:builder by [@EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3943](https://togithub.com/bazelbuild/rules_go/pull/3943) - prepare v0.48.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3946](https://togithub.com/bazelbuild/rules_go/pull/3946) #### New Contributors - [@stefanpenner](https://togithub.com/stefanpenner) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) **Full Changelog**: bazel-contrib/rules_go@v0.47.1...v0.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.47.1` -> `v0.48.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.48.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.1...v0.48.0) #### Important Changes! `--incompatible_enable_proto_toolchain_resolution` is now supported in `rules_go`. This means that protoc should now be supplied as a toolchain. `protoc` can be registered using https://github.com/aspect-build/toolchains_protoc, or a local proto toolchain can be added. #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "33acc4ae0f70502db4b893c9fc1dd7a9bf998c23e7ff2c4517741d4049a976f8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.3") #### What's Changed - Update docs to cover new FilePath ReplaceDirective Support by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) - go_test: use different mnemonic for compilation by [@sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3936](https://togithub.com/bazelbuild/rules_go/pull/3936) - Add go.work support to the documentation by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3932](https://togithub.com/bazelbuild/rules_go/pull/3932) - feat(mode): add `purego` tag when `pure` by [@mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3901](https://togithub.com/bazelbuild/rules_go/pull/3901) - generate_test_main: Move timeout handling back to bzltestutil by [@DolceTriade](https://togithub.com/DolceTriade) in [https://github.com/bazelbuild/rules_go/pull/3939](https://togithub.com/bazelbuild/rules_go/pull/3939) - Add support for `--incompatible_enable_proto_toolchain_resolution` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3919](https://togithub.com/bazelbuild/rules_go/pull/3919) - Add exec_compatible_with to @go_sdk//:builder by [@EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3943](https://togithub.com/bazelbuild/rules_go/pull/3943) - prepare v0.48.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3946](https://togithub.com/bazelbuild/rules_go/pull/3946) #### New Contributors - [@stefanpenner](https://togithub.com/stefanpenner) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) **Full Changelog**: bazel-contrib/rules_go@v0.47.1...v0.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.47.1` -> `v0.48.0` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.48.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.1...v0.48.0) #### Important Changes! `--incompatible_enable_proto_toolchain_resolution` is now supported in `rules_go`. This means that protoc should now be supplied as a toolchain. `protoc` can be registered using https://github.com/aspect-build/toolchains_protoc, or a local proto toolchain can be added. #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "33acc4ae0f70502db4b893c9fc1dd7a9bf998c23e7ff2c4517741d4049a976f8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.3") #### What's Changed - Update docs to cover new FilePath ReplaceDirective Support by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) - go_test: use different mnemonic for compilation by [@sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3936](https://togithub.com/bazelbuild/rules_go/pull/3936) - Add go.work support to the documentation by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3932](https://togithub.com/bazelbuild/rules_go/pull/3932) - feat(mode): add `purego` tag when `pure` by [@mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3901](https://togithub.com/bazelbuild/rules_go/pull/3901) - generate_test_main: Move timeout handling back to bzltestutil by [@DolceTriade](https://togithub.com/DolceTriade) in [https://github.com/bazelbuild/rules_go/pull/3939](https://togithub.com/bazelbuild/rules_go/pull/3939) - Add support for `--incompatible_enable_proto_toolchain_resolution` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3919](https://togithub.com/bazelbuild/rules_go/pull/3919) - Add exec_compatible_with to @go_sdk//:builder by [@EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3943](https://togithub.com/bazelbuild/rules_go/pull/3943) - prepare v0.48.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3946](https://togithub.com/bazelbuild/rules_go/pull/3946) #### New Contributors - [@stefanpenner](https://togithub.com/stefanpenner) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) **Full Changelog**: bazel-contrib/rules_go@v0.47.1...v0.48.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/bazel-contrib/toolchains_llvm).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

zecke · 2024-06-12T14:02:57Z

This change causes a significant performance (from ms to seconds) impact when handling protobuf. I would like to continue using pure binaries and allow unsafe/pointer arithmetic when compiling protobuf.

mattyclarkson · 2024-06-13T09:31:13Z

The performance regression discussion is continuing in #3959

This reverts commit fcd6390. `purego` regresses performance of certain third-party libraries (see #3959).

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://togithub.com/bazelbuild/rules_go) | http_archive | minor | `v0.47.0` -> `v0.48.1` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.48.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.1) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.48.0...v0.48.1) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "b2038e2de2cace18f032249cb4bb0048abf583a36369fa98f687af1b3f880b26", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.1/rules_go-v0.48.1.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.1/rules_go-v0.48.1.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.4") **Full Changelog**: bazel-contrib/rules_go@v0.48.0...v0.48.1 ### [`v0.48.0`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.48.0) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.1...v0.48.0) #### Important Changes! `--incompatible_enable_proto_toolchain_resolution` is now supported in `rules_go`. This means that protoc should now be supplied as a toolchain. `protoc` can be registered using https://github.com/aspect-build/toolchains_protoc, or a local proto toolchain can be added. [`rules_proto`](https://togithub.com/bazelbuild/rules_proto) 6.0.0 is required to use Go proto rules. #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "33acc4ae0f70502db4b893c9fc1dd7a9bf998c23e7ff2c4517741d4049a976f8", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.48.0/rules_go-v0.48.0.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.3") #### What's Changed - Update docs to cover new FilePath ReplaceDirective Support by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) - go_test: use different mnemonic for compilation by [@sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3936](https://togithub.com/bazelbuild/rules_go/pull/3936) - Add go.work support to the documentation by [@stefanpenner](https://togithub.com/stefanpenner) in [https://github.com/bazelbuild/rules_go/pull/3932](https://togithub.com/bazelbuild/rules_go/pull/3932) - feat(mode): add `purego` tag when `pure` by [@mattyclarkson](https://togithub.com/mattyclarkson) in [https://github.com/bazelbuild/rules_go/pull/3901](https://togithub.com/bazelbuild/rules_go/pull/3901) - generate_test_main: Move timeout handling back to bzltestutil by [@DolceTriade](https://togithub.com/DolceTriade) in [https://github.com/bazelbuild/rules_go/pull/3939](https://togithub.com/bazelbuild/rules_go/pull/3939) - Add support for `--incompatible_enable_proto_toolchain_resolution` by [@fmeum](https://togithub.com/fmeum) in [https://github.com/bazelbuild/rules_go/pull/3919](https://togithub.com/bazelbuild/rules_go/pull/3919) - Add exec_compatible_with to @go_sdk//:builder by [@EdSchouten](https://togithub.com/EdSchouten) in [https://github.com/bazelbuild/rules_go/pull/3943](https://togithub.com/bazelbuild/rules_go/pull/3943) - prepare v0.48.0 release by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3946](https://togithub.com/bazelbuild/rules_go/pull/3946) #### New Contributors - [@stefanpenner](https://togithub.com/stefanpenner) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3931](https://togithub.com/bazelbuild/rules_go/pull/3931) **Full Changelog**: bazel-contrib/rules_go@v0.47.1...v0.48.0 ### [`v0.47.1`](https://togithub.com/bazelbuild/rules_go/releases/tag/v0.47.1) [Compare Source](https://togithub.com/bazelbuild/rules_go/compare/v0.47.0...v0.47.1) #### `WORKSPACE` code load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "f74c98d6df55217a36859c74b460e774abc0410a47cc100d822be34d5f990f16", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.47.1/rules_go-v0.47.1.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.47.1/rules_go-v0.47.1.zip", ], ) load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.22.2") #### What's Changed - bzltestutil: restore timeout signal handler by [@sluongng](https://togithub.com/sluongng) in [https://github.com/bazelbuild/rules_go/pull/3929](https://togithub.com/bazelbuild/rules_go/pull/3929) - feat: support syso files in srcs. by [@connyay](https://togithub.com/connyay) in [https://github.com/bazelbuild/rules_go/pull/3763](https://togithub.com/bazelbuild/rules_go/pull/3763) - prepare patch release 0.47.1 by [@tyler-french](https://togithub.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3933](https://togithub.com/bazelbuild/rules_go/pull/3933) #### New Contributors - [@connyay](https://togithub.com/connyay) made their first contribution in [https://github.com/bazelbuild/rules_go/pull/3763](https://togithub.com/bazelbuild/rules_go/pull/3763) **Full Changelog**: bazel-contrib/rules_go@v0.47.0...v0.47.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).  Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>

mattyclarkson commented Mar 22, 2024

View reviewed changes

go/private/mode.bzl Show resolved Hide resolved

mattyclarkson mentioned this pull request Mar 28, 2024

Ignore purego build constraint bazel-contrib/bazel-gazelle#1767

Merged

mattyclarkson force-pushed the purego branch 4 times, most recently from 610327f to 8d0ad1e Compare April 6, 2024 15:53

mattyclarkson force-pushed the purego branch 2 times, most recently from 4d1e036 to c273e90 Compare April 6, 2024 17:02

mattyclarkson force-pushed the purego branch from c273e90 to 2a303d0 Compare April 10, 2024 08:42

mattyclarkson mentioned this pull request Apr 24, 2024

feat(rules_git): add 1.0.0-alpha.1 bazelbuild/bazel-central-registry#1868

Closed

mattyclarkson force-pushed the purego branch from 2a303d0 to 587e461 Compare April 25, 2024 07:28

mattyclarkson force-pushed the purego branch 3 times, most recently from b1536ac to c08a320 Compare May 7, 2024 10:26

mattyclarkson force-pushed the purego branch from c08a320 to 3f59887 Compare May 7, 2024 19:40

tyler-french approved these changes May 8, 2024

View reviewed changes

fmeum merged commit fcd6390 into bazel-contrib:master May 8, 2024
2 checks passed

mattyclarkson deleted the purego branch May 8, 2024 19:42

mattyclarkson mentioned this pull request May 8, 2024

Support pure = "on" for [email protected] bazelbuild/bazel-central-registry#1629

Closed

fmeum added a commit that referenced this pull request Jun 14, 2024

Revert "feat(mode): add purego tag when pure (#3901)"

d855b3e

This reverts commit fcd6390. `purego` regresses performance of certain third-party libraries (see #3959).

fmeum added a commit that referenced this pull request Jun 18, 2024

Revert "feat(mode): add purego tag when pure (#3901)" (#3961)

f81ce9f

This reverts commit fcd6390. `purego` regresses performance of certain third-party libraries (see #3959).

tyler-french pushed a commit that referenced this pull request Jun 19, 2024

Revert "feat(mode): add purego tag when pure (#3901)" (#3961)

5a49550

This reverts commit fcd6390. `purego` regresses performance of certain third-party libraries (see #3959).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(mode): add `purego` tag when `pure` #3901

feat(mode): add `purego` tag when `pure` #3901

mattyclarkson commented Mar 22, 2024

mattyclarkson commented Mar 26, 2024

mattyclarkson commented Apr 6, 2024 •

edited

Loading

fmeum commented Apr 6, 2024 •

edited

Loading

mattyclarkson commented Apr 6, 2024

fmeum commented Apr 6, 2024

mattyclarkson commented May 7, 2024

tyler-french commented May 7, 2024

tyler-french commented May 8, 2024

tyler-french left a comment

mattyclarkson commented May 8, 2024 •

edited

Loading

zecke commented Jun 12, 2024

mattyclarkson commented Jun 13, 2024 •

edited

Loading

feat(mode): add purego tag when pure #3901

feat(mode): add purego tag when pure #3901

Conversation

mattyclarkson commented Mar 22, 2024

mattyclarkson commented Mar 26, 2024

mattyclarkson commented Apr 6, 2024 • edited Loading

fmeum commented Apr 6, 2024 • edited Loading

mattyclarkson commented Apr 6, 2024

fmeum commented Apr 6, 2024

mattyclarkson commented May 7, 2024

tyler-french commented May 7, 2024

tyler-french commented May 8, 2024

tyler-french left a comment

Choose a reason for hiding this comment

mattyclarkson commented May 8, 2024 • edited Loading

zecke commented Jun 12, 2024

mattyclarkson commented Jun 13, 2024 • edited Loading

feat(mode): add `purego` tag when `pure` #3901

feat(mode): add `purego` tag when `pure` #3901

mattyclarkson commented Apr 6, 2024 •

edited

Loading

fmeum commented Apr 6, 2024 •

edited

Loading

mattyclarkson commented May 8, 2024 •

edited

Loading

mattyclarkson commented Jun 13, 2024 •

edited

Loading