Hotfix version parsing breaking build by ignoring non-semver (#55)

FIXES #54

data/moduleStaticProps.ts

@@ -1,4 +1,4 @@
-import compareVersions from 'compare-versions'
+import { compareVersions, validate as validateVersion } from 'compare-versions'
 import {
   extractModuleInfo,
   getModuleMetadata,
@@ -24,8 +24,8 @@ export const getStaticPropsModulePage = async (
   version: string | null
 ) => {
   const metadata = await getModuleMetadata(module)
-  const { versions } = metadata
-  versions.sort(compareVersions)
+  let { versions } = metadata
+  versions = sortVersions(versions)
 
   const versionInfos: VersionInfo[] = await Promise.all(
     versions.map(async (version) => ({
@@ -48,3 +48,21 @@ export const getStaticPropsModulePage = async (
     },
   }
 }
+
+/**
+ * Sort versions, by splitting them into sortable and unsortable ones.
+ *
+ * The sortable versions will form the start of the list and are sorted, while the unsortable ones will
+ * form the end of it.
+ *
+ * This is mostly a placeholder until we have proper version parsing and comparison
+ * (see discussion in https://github.com/bazel-contrib/bcr-ui/issues/54).
+ */
+const sortVersions = (versions: string[]): string[] => {
+  const sortableVersions = versions.filter((version) => validateVersion(version))
+  const unsortableVersions = versions.filter((version) => !validateVersion(version))
+  sortableVersions.sort(compareVersions)
+  sortableVersions.reverse()
+
+  return [...sortableVersions,...unsortableVersions];
+}

package.json

@@ -18,7 +18,7 @@
     "@fortawesome/free-regular-svg-icons": "^6.1.1",
     "@fortawesome/free-solid-svg-icons": "^6.1.1",
     "@fortawesome/react-fontawesome": "^0.1.18",
-    "compare-versions": "^4.1.3",
+    "compare-versions": "^6.0.0-rc.1",
     "date-fns": "^2.28.0",
     "execa": "^6.1.0",
     "fuse.js": "^6.6.2",

pages/modules/[module].tsx

@@ -1,17 +1,12 @@
 import type { GetStaticProps, NextPage } from 'next'
-import compareVersions from 'compare-versions'
 import Head from 'next/head'
 import Link from 'next/link'
 import { useRouter } from 'next/router'
 import { Header, USER_GUIDE_LINK } from '../../components/Header'
 import { Footer } from '../../components/Footer'
 import {
-  extractModuleInfo,
-  getModuleMetadata,
-  getSubmissionCommitOfVersion,
   listModuleNames,
   Metadata,
-  ModuleInfo,
 } from '../../data/utils'
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome'
 import { faGithub } from '@fortawesome/free-brands-svg-icons'
@@ -46,7 +41,6 @@ const ModulePage: NextPage<ModulePageProps> = ({
   const displayShowAllButton = isQualifiedForShowAll && !triggeredShowAll
 
   const versionInfo = versionInfos.find((n) => n.version === selectedVersion)
-  const versionsInOrder = versionInfos.slice().reverse()
 
   const githubLink = metadata.repository
     ?.find((repo) => repo.startsWith('github:'))
@@ -56,8 +50,8 @@ const ModulePage: NextPage<ModulePageProps> = ({
     : undefined
 
   const shownVersions = triggeredShowAll
-    ? versionsInOrder
-    : versionsInOrder.slice(0, NUM_VERSIONS_ON_PAGE_LOAD)
+    ? versionInfos
+    : versionInfos.slice(0, NUM_VERSIONS_ON_PAGE_LOAD)
 
   if (!versionInfo) {
     throw Error(

pages/modules/[module]/[version].tsx

@@ -1,13 +1,9 @@
 import ModulePage from '../[module]'
 import { GetStaticProps } from 'next'
 import {
-  extractModuleInfo,
-  getModuleMetadata,
-  getSubmissionCommitOfVersion,
   listModuleNames,
   listModuleVersions,
 } from '../../../data/utils'
-import compareVersions from 'compare-versions'
 import { getStaticPropsModulePage } from '../../../data/moduleStaticProps'
 
 export const getStaticProps: GetStaticProps = async ({ params }) => {