Add team sidebar display conditions #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Overall looks good! Left a comment about nullness / undefinedness.
It turns out that sidebar is the only component right now with tests, so we'll need to update those tests before merging this PR. I believe the change we'll need to make is to add a <CurrentUserContext.Provider> and <CurrentTeamContext.Provider> to wrap the <Sidebar> in the tests. You can find the test at components/sidebar/test/Sidebar.test.tsx
Comment on lines
101
to
102
| if (!isNull(user) && user !== undefined) { | ||
| if (!isNull(team) && team !== undefined) { |
There was a problem hiding this comment.
user and team should never be null (you can hover over them to see the types). This means we can just check !isUndefined(user) and !isUndefined(team) for these if statements
acrantel
approved these changes
Oct 22, 2023
acrantel
pushed a commit
that referenced
this pull request
Feb 8, 2024
acrantel
pushed a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user is not logged in, the entire TEAM MANAGEMENT section of the sidebar should not appear
If the user is logged in and does not have a team, the Submissions and Scrimmaging sections should not appear
If the user is logged in and has a team, the entire TEAM MANAGEMENT section should appear