Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the my team settings page #680

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Add the my team settings page #680

merged 3 commits into from
Oct 24, 2023

Conversation

acrantel
Copy link
Member

@acrantel acrantel commented Sep 30, 2023 •
edited
Loading

Adds the team settings page. This PR doesn't add any functionality - only the design.
TODO:

  • profile section
  • elgibility and scrimmages sections
    • fancy checkboxes (DescriptiveCheckbox component)
  • members list
  • no team? display team join stub
  • leave team button

image

@acrantel acrantel changed the base branch from frontend2 to main September 30, 2023 18:33
@acrantel acrantel changed the base branch from main to frontend2 September 30, 2023 18:33
@acrantel acrantel force-pushed the serena/actualmyteam branch 3 times, most recently from a3f7a10 to 40573e5 Compare October 21, 2023 19:00
@acrantel acrantel force-pushed the serena/actualmyteam branch from 40573e5 to 2686f2a Compare October 21, 2023 19:01
@acrantel acrantel marked this pull request as ready for review October 21, 2023 19:02
@acrantel acrantel changed the title WIP: Add the my team settings page Add the my team settings page Oct 21, 2023
lowtorola
lowtorola requested changes Oct 21, 2023
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for your perusal, otherwise looks good!

frontend2/src/components/team/MemberList.tsx Outdated Show resolved Hide resolved
frontend2/src/views/MyTeam.tsx
<Input
disabled
label="Join key"
value={team.join_key ?? "Loading..."}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a spinner here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

b/c it's an input field I'm hesitant to add a spinner; we may want to consider making the whole page a spinner while the team is loading instead, but that can be added later

frontend2/src/views/MyTeam.tsx Outdated Show resolved Hide resolved
@acrantel acrantel requested a review from lowtorola October 23, 2023 01:10
lowtorola
lowtorola approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@lowtorola lowtorola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ⭐

@acrantel acrantel merged commit 62b6032 into frontend2 Oct 24, 2023
3 checks passed
@acrantel acrantel deleted the serena/actualmyteam branch October 24, 2023 20:29
acrantel added a commit that referenced this pull request Feb 8, 2024
@acrantel
Add the my team settings page (#680)
329829b
acrantel added a commit that referenced this pull request Feb 8, 2024
@acrantel
Add the my team settings page (#680)
b8494d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowtorola lowtorola lowtorola approved these changes

@sri240 sri240 Awaiting requested review from sri240

@nicolexxuu nicolexxuu Awaiting requested review from nicolexxuu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@acrantel @lowtorola