implement basher upgrade --all

[pforret]

as requested, implemented basher upgrade --all as a piped basher-list | xargs -n1 basher upgrade

[hyperupcall]

Should this be exit, so if any of the basher upgrades fail, the non-zero exit code is perserved?

[pforret]

Fair point. I've adapted it!

[juanibiapina]

Good start. We're just missing the tests for this case.

[juanibiapina]

Could you please move this ignore line to your personal gitignore?

[juanibiapina]

When we have tests we can check the behavior of xargs in practice, but I think in this case it will return 0 if at least one basher upgrade is successful, which means the whole script would return 0 even if some packages failed to upgrade.

[pawamoy]

From the manpage:

xargs exits with the following status:

              0      if it succeeds

              123    if any invocation of the command exited with status 1-125

              124    if the command exited with status 255

              125    if the command is killed by a signal

              126    if the command cannot be run

              127    if the command is not found

              1      if some other error occurred.

       Exit codes greater than 128 are used by the shell to  indicate  that  a
       program died due to a fatal signal.

[juanibiapina]

this doesn't answer the question though. If 0 means every basher upgrade succeeded or at least one.

[pawamoy]

It was mostly for reference. But I would interpret it as, only return 0 if all invocations returned 0. Otherwise return 123. Anyway, needs confirmation through tests indeed 🙂

[pawamoy]

$ echo 'exit $1' > s
$ for i in {0..10}; do echo $i; done | xargs -n1 bash s
$ echo $?
123
$ for i in 0 0 0; do echo $i; done | xargs -n1 bash s
$ echo $?
0