Restructure environmentVariablesUsed detection to avoid falsely alerting #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skovhus
reviewed
Sep 21, 2024
| const environmentVariablesUsed = Object.entries(rawConfig) | ||
| .map(([key, value]) => (typeof value !== 'undefined' ? key : null)) | ||
| .filter((key): key is string => key !== null) | ||
| .filter((key) => key !== 'logLevel') // logLevel is a special case that we ignore |
There was a problem hiding this comment.
Why don't we filter out shfmt here like we already filter out loglevel?
There was a problem hiding this comment.
Personal preference, if I'm honest. I trend towards exhaustivity checks, where possible, but I'm happy to switch it back to the way it was and add a test to the filter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid incorrectly warning the user of
shfmtenvvar configuration:Thank you!