shellcheck: add code actions to disable rule #1069
Open
+2,274
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements bash-lsp#933. Always add a code action to disable a given diagnostic for a given line or for the whole file. This patch handles: * indentation * existing directive. It also sorts the disable directives if any * multi-line command Add corresponding tests. Signed-off-by: Thomas Faivre <[email protected]>
ThomasFaivre
force-pushed
the
fix_933_v2
branch
from
9f94f89 to
dd1f805
Compare
skovhus
reviewed
Dec 28, 2023
| @@ -222,7 +222,7 @@ describe('server', () => { | |||
| {} as any, | |||
| ) | |||
|
|
|||
| expect(result).toHaveLength(1) | |||
| expect(result).toHaveLength(3) | |||
There was a problem hiding this comment.
Let us check what all the code actions are about. Consider just doing a snapshot test of the entire result object.
| result, | ||
| }: { | ||
| document: TextDocument | ||
| uri: string |
There was a problem hiding this comment.
No reason to pass in the uri if we have the document.
| lineNb, | ||
| }: { | ||
| document: TextDocument | ||
| lineNb: number |
There was a problem hiding this comment.
Nit: the nb abbreviation and postfix seems unnecessary.
| }) | ||
| } | ||
|
|
||
| // TODO: use directives module |
|
|
||
| private static getIndentation(line: string): string { | ||
| const match = line.match(/^([\s]*)/) | ||
| if (match && match[1]) { |
There was a problem hiding this comment.
Probably worth exploring using the AST for this.
|
@ThomasFaivre are you going to be working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following my comment in #933, I ended up finishing my draft.
It is now fully functionnal:
Tested with Neovim (NVIM v0.10.0-dev-1846+gf31f260f0).
Therefore, I would like your opinion on the implementation.
I have already spotted some room for improvements:
What do you think?
Thanks!